From: Randy Dunlap <randy.dunlap@oracle.com>
To: Corey Minyard <minyard@acm.org>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
OpenIPMI Developers <openipmi-developer@lists.sourceforge.net>,
Joseph Barnett <jbarnett@motorola.com>
Subject: Re: [PATCH 9/12] IPMI: add pigeonpoint poweroff
Date: Sun, 3 Dec 2006 19:00:56 -0800 [thread overview]
Message-ID: <20061203190056.2d8b3540.randy.dunlap@oracle.com> (raw)
In-Reply-To: <45738959.1000209@acm.org>
On Sun, 03 Dec 2006 20:35:05 -0600 Corey Minyard wrote:
> Andrew Morton wrote:
> > On Fri, 1 Dec 2006 22:37:46 -0600
> > Corey Minyard <minyard@acm.org> wrote:
> >
> >
> >> +static void (*atca_oem_poweroff_hook)(ipmi_user_t user) = NULL;
> >>
> >
> > Sometime, please go through the IPMI code looking for all these
> > statically-allocated things which are initialised to 0 or NULL and remove
> > all those intialisations? They're unneeded, they increase the vmlinux
> > image size and there are quite a number of them. Thanks.
> >
> I'll do that, thanks, and I'll work on the other changes you suggest.
BTW, how about killing this comment or at least the email address part of it:
ipmi_bt_sm.c: * Author: Rocky Craig <first.last@hp.com>
---
~Randy
next prev parent reply other threads:[~2006-12-04 3:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-02 4:37 Corey Minyard
2006-12-03 21:26 ` Andrew Morton
2006-12-04 2:35 ` Corey Minyard
2006-12-04 2:54 ` Randy Dunlap
2006-12-04 3:53 ` [Openipmi-developer] " Bela Lubkin
2006-12-04 4:01 ` Randy Dunlap
2006-12-04 4:12 ` Randy Dunlap
2006-12-05 14:01 ` Corey Minyard
2006-12-05 16:19 ` Bela Lubkin
2006-12-04 4:21 ` Bela Lubkin
2006-12-04 12:06 ` Horst H. von Brand
2006-12-04 3:00 ` Randy Dunlap [this message]
2006-12-04 5:03 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061203190056.2d8b3540.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@osdl.org \
--cc=jbarnett@motorola.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®