mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: "'Zach Brown'" <zach.brown@oracle.com>,
	"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [patch] remove redundant iov segment check
Date: Mon, 4 Dec 2006 11:36:09 -0800	[thread overview]
Message-ID: <20061204113609.753069b9.akpm@osdl.org> (raw)
In-Reply-To: <000001c717c0$f82b5ea0$2589030a@amr.corp.intel.com>

On Mon, 4 Dec 2006 08:26:36 -0800
"Chen, Kenneth W" <kenneth.w.chen@intel.com> wrote:

> So it's not possible to call down to generic_file_aio_read/write with invalid
> iov segment.  Patch proposed to delete these redundant code.

erp, please don't touch that code.

The writev deadlock fixes which went into 2.6.17 trashed writev()
performance and Nick and I are slowly trying to get it back, while fixing
the has-been-there-forever pagefault-in-write() deadlock.

This is all proving very hard to do, and we don't need sweeping code
cleanups happening under our feet ;)

I'll bring those patches back in next -mm, but not very confidently.

  parent reply	other threads:[~2006-12-04 19:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-04 16:26 Chen, Kenneth W
2006-12-04 19:18 ` Zach Brown
2006-12-04 19:45   ` Chen, Kenneth W
2006-12-04 19:50     ` Zach Brown
2007-01-02 11:01   ` Christoph Hellwig
2007-01-02 18:22     ` Zach Brown
2007-01-02 18:25       ` Chen, Kenneth W
2006-12-04 19:36 ` Andrew Morton [this message]
2006-12-04 19:50   ` Chen, Kenneth W

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061204113609.753069b9.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=kenneth.w.chen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zach.brown@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®