From: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, cornelia.huck@de.ibm.com
Subject: Re: [S390] cio: Make ccw_dev_id_is_equal() more robust.
Date: Mon, 4 Dec 2006 10:23:48 -0500 [thread overview]
Message-ID: <20061204152348.GA30961@filer.fsl.cs.sunysb.edu> (raw)
In-Reply-To: <20061204145624.GB32059@skybase>
On Mon, Dec 04, 2006 at 03:56:24PM +0100, Martin Schwidefsky wrote:
...
> diff -urpN linux-2.6/include/asm-s390/cio.h linux-2.6-patched/include/asm-s390/cio.h
> --- linux-2.6/include/asm-s390/cio.h 2006-12-04 14:50:48.000000000 +0100
> +++ linux-2.6-patched/include/asm-s390/cio.h 2006-12-04 14:51:00.000000000 +0100
> @@ -278,7 +278,10 @@ struct ccw_dev_id {
> static inline int ccw_dev_id_is_equal(struct ccw_dev_id *dev_id1,
> struct ccw_dev_id *dev_id2)
> {
> - return !memcmp(dev_id1, dev_id2, sizeof(struct ccw_dev_id));
> + if ((dev_id1->ssid == dev_id2->ssid) &&
> + (dev_id1->devno == dev_id2->devno))
> + return 1;
> + return 0;
> }
Why not just:
return ((dev_id1->ssid == ......) && (...));
?
Josef "Jeff" Sipek.
--
UNIX is user-friendly ... it's just selective about who it's friends are
next prev parent reply other threads:[~2006-12-04 15:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-04 14:56 Martin Schwidefsky
2006-12-04 15:23 ` Josef Sipek [this message]
2006-12-04 15:30 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061204152348.GA30961@filer.fsl.cs.sunysb.edu \
--to=jsipek@fsl.cs.sunysb.edu \
--cc=cornelia.huck@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®