Re: [patch] add ignore_loglevel boot option

[Randy Dunlap <randy.dunlap@oracle.com>]

On Tue, 5 Dec 2006 13:09:54 +0100 Ingo Molnar wrote:

> Subject: [patch] add ignore_loglevel boot option
> From: Ingo Molnar <mingo@elte.hu>
> 
> sometimes the kernel prints something interesting while userspace
> bootup keeps messages turned off via loglevel. Enable the printing
> of /all/ kernel messages via the "ignore_loglevel" boot option.
> Off by default.

Hi,

Is this equivalent to using the "debug" kernel parameter
except that userspace (init scripts) cannot muck it up (modify
the setting)?

I've seen init scripts modify the loglevel, much to my
dismay.

I'd say that this is useful, but it's really userspace
that needs to be fixed.

> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
>  Documentation/kernel-parameters.txt |    4 ++++
>  kernel/printk.c                     |   14 +++++++++++++-
>  2 files changed, 17 insertions(+), 1 deletion(-)
> 
> Index: linux/kernel/printk.c
> ===================================================================
> --- linux.orig/kernel/printk.c
> +++ linux/kernel/printk.c
> @@ -352,13 +352,25 @@ static void __call_console_drivers(unsig
>  	touch_critical_timing();
>  }
>  
> +static int __read_mostly ignore_loglevel;
> +
> +int __init ignore_loglevel_setup(char *str)
> +{
> +	ignore_loglevel = 1;
> +	printk(KERN_INFO "debug: ignoring loglevel setting.\n");
> +
> +	return 1;
> +}
> +
> +__setup("ignore_loglevel", ignore_loglevel_setup);
> +
>  /*
>   * Write out chars from start to end - 1 inclusive
>   */
>  static void _call_console_drivers(unsigned long start,
>  				unsigned long end, int msg_log_level)
>  {
> -	if (msg_log_level < console_loglevel &&
> +	if ((msg_log_level < console_loglevel || ignore_loglevel) &&
>  			console_drivers && start != end) {
>  		if ((start & LOG_BUF_MASK) > (end & LOG_BUF_MASK)) {
>  			/* wrapped write */
> -

---
~Randy