From: Ingo Molnar <mingo@elte.hu>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
"'Andrew Morton'" <akpm@osdl.org>,
"'Christoph Lameter'" <clameter@sgi.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [-mm patch] sched remove lb_stopbalance counter
Date: Tue, 5 Dec 2006 16:32:24 +0100 [thread overview]
Message-ID: <20061205153224.GA3204@elte.hu> (raw)
In-Reply-To: <000001c71881$1ad82850$a884030a@amr.corp.intel.com>
* Chen, Kenneth W <kenneth.w.chen@intel.com> wrote:
> in -mm tree: I would like to revert the change on adding
> lb_stopbalance counter. This count can be calculated by: lb_balanced
> - lb_nobusyg - lb_nobusyq. There is no need to create gazillion
> counters while we can derive the value. I'm more of against changing
> sched-stat format unless it is absolutely necessary as all user land
> tool parsing /proc/schedstat needs to be updated and it's a real pain
> trying to keep multiple versions of it.
>
> Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>
Acked-by: Ingo Molnar <mingo@elte.hu>
but, please:
> -#define SCHEDSTAT_VERSION 13
> +#define SCHEDSTAT_VERSION 12
change this to 14 instead. Versions should only go upwards, even if we
revert to an earlier output format.
Ingo
next prev parent reply other threads:[~2006-12-05 15:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-05 15:21 Chen, Kenneth W
2006-12-05 15:32 ` Ingo Molnar [this message]
2006-12-05 15:38 ` Chen, Kenneth W
2006-12-05 15:41 ` Ingo Molnar
2006-12-05 18:57 ` Chen, Kenneth W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061205153224.GA3204@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®