From: Andrew Morton <akpm@osdl.org>
To: Dave Kleikamp <shaggy@ltc.vnet.ibm.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] freezer.h uses task_struct fields
Date: Fri, 8 Dec 2006 13:01:55 -0800 [thread overview]
Message-ID: <20061208130155.c6cf85e1.akpm@osdl.org> (raw)
In-Reply-To: <1165588271.8686.8.camel@kleikamp.austin.ibm.com>
On Fri, 08 Dec 2006 08:31:11 -0600
Dave Kleikamp <shaggy@ltc.vnet.ibm.com> wrote:
> > include/linux/freezer.h: In function 'frozen_process':
> > include/linux/freezer.h:55: error: dereferencing pointer to incomplete type
> > include/linux/freezer.h:55: error: dereferencing pointer to incomplete type
> > include/linux/freezer.h:55: error: 'PF_FREEZE' undeclared (first use in this function)
> > include/linux/freezer.h:55: error: 'PF_FROZEN' undeclared (first use in this function)
> > fs/jfs/jfs_txnmgr.c: In function 'freezing':
> > include/linux/freezer.h:18: warning: control reaches end of non-void function
> > make[2]: *** [fs/jfs/jfs_txnmgr.o] Error 1
>
> Defining CONFIG_SMP or CONFIG_PREEMPT masks this problem (at least in
> jfs), since smp_lock.h will include sched.h when CONFIG_LOCK_KERNEL is
> defined, and smp_lock.h happens to be included by jfs_txngmr.c before
> freezer.h.
>
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>
> Acked-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
OK, thanks guys. This is the sort of patch which I like to put
through a decent round of cross-compilation testing, so it's unlikely
to appear in mainline for 2-3 days.
prev parent reply other threads:[~2006-12-08 21:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 6:13 Randy Dunlap
2006-12-08 14:31 ` Dave Kleikamp
2006-12-08 14:52 ` Dave Kleikamp
2006-12-08 21:01 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061208130155.c6cf85e1.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=shaggy@ltc.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®