From: Andrew Morton <akpm@osdl.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>, phil.el@wanadoo.fr, ak@suse.de
Subject: Re: [PATCH] x86 smp: export smp_num_siblings for oprofile
Date: Sat, 9 Dec 2006 00:49:39 -0800 [thread overview]
Message-ID: <20061209004939.85d72e2c.akpm@osdl.org> (raw)
In-Reply-To: <20061209003424.cecc58a4.randy.dunlap@oracle.com>
On Sat, 9 Dec 2006 00:34:24 -0800
Randy Dunlap <randy.dunlap@oracle.com> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> oprofile uses smp_num_siblings without testing for CONFIG_X86_HT.
> I looked at modifying oprofile, but this way is cleaner & simpler
> and I didn't see a good reason not to just export it when CONFIG_SMP.
>
> WARNING: "smp_num_siblings" [arch/i386/oprofile/oprofile.ko] undefined!
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> arch/i386/kernel/smpboot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.19-git13.orig/arch/i386/kernel/smpboot.c
> +++ linux-2.6.19-git13/arch/i386/kernel/smpboot.c
> @@ -69,7 +69,7 @@ static int __devinitdata smp_b_stepping;
>
> /* Number of siblings per CPU package */
> int smp_num_siblings = 1;
> -#ifdef CONFIG_X86_HT
> +#ifdef CONFIG_SMP
> EXPORT_SYMBOL(smp_num_siblings);
> #endif
smpboot.c isn't compiled if CONFIG_SMP=n, so I'll just remove the ifdef,
thanks.
prev parent reply other threads:[~2006-12-09 8:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-09 8:34 Randy Dunlap
2006-12-09 8:49 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061209004939.85d72e2c.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=phil.el@wanadoo.fr \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®