Re: sysfs file creation result nightmare (WAS radeonfb: Fix sysfs_create_bin_file warnings)

[Andrew Morton <akpm@osdl.org>]

On Sat, 9 Dec 2006 22:44:53 +0100
Olivier Galibert <galibert@pobox.com> wrote:

> On Sat, Dec 09, 2006 at 12:38:17PM -0800, Andrew Morton wrote:
> > On Sun, 10 Dec 2006 06:59:10 +1100
> > Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> > > Why would I prevent the framebuffer from initializing (and thus a
> > > console to be displayed at all on many machines) just because for some
> > > reason, I couldn't create a pair of EDID files in sysfs that are not
> > > even very useful anymore ?
> > 
> > Because there's a bug in your kernel.  We don't hide and work around bugs.
> 
> Hmmm, I don't understand.  Which is the bug, having a sysfs file
> creation fail or going on if it happens?

Probably the former, probably the latter.

There may be situations in which we want do to "create this sysfs file if
it doesn't already exist", but I'm not aware of any such.

Generally speaking, if sysfs file creation went wrong, it's due to a bug. 
The result is that the driver isn't working as intended: tunables or
instrumentation which it is designed to make available are not present.  We
want to know about that bug asap so we can get it fixed.