mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Andrew Morton <akpm@osdl.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
	Al Viro <viro@ftp.linux.org.uk>,
	Andrew MChuck Ebbert <76306.1226@compuserve.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] pipe: Don't oops when pipe filesystem isn't mounted
Date: Mon, 11 Dec 2006 21:17:42 -0500	[thread overview]
Message-ID: <20061212021742.GA2820@isilmar.linta.de> (raw)
In-Reply-To: <20061211180822.5f7814d5.akpm@osdl.org>

On Mon, Dec 11, 2006 at 06:08:22PM -0800, Andrew Morton wrote:
> > diff --git a/include/linux/init.h b/include/linux/init.h
> > index 5eb5d24..5a593a1 100644
> > --- a/include/linux/init.h
> > +++ b/include/linux/init.h
> > @@ -111,6 +111,7 @@ extern void setup_arch(char **);
> >  #define subsys_initcall_sync(fn)	__define_initcall("4s",fn,4s)
> >  #define fs_initcall(fn)			__define_initcall("5",fn,5)
> >  #define fs_initcall_sync(fn)		__define_initcall("5s",fn,5s)
> > +#define rootfs_initcall(fn)		__define_initcall("rootfs",fn,rootfs)
> >  #define device_initcall(fn)		__define_initcall("6",fn,6)
> >  #define device_initcall_sync(fn)	__define_initcall("6s",fn,6s)
> >  #define late_initcall(fn)		__define_initcall("7",fn,7)
> 
> Looks like this might break pcmcia which for some reason does firmware
> requesting at fs_initcall level (drivers/pcmcia/ds.c).

That codepath is not triggered before device_initcall()s occur. So it's a
non-issue for PCMCIA.

Thanks,
	Dominik

  reply	other threads:[~2006-12-12  2:17 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-11  8:27 Chuck Ebbert
2006-12-11  8:55 ` Andrew Morton
2006-12-11  9:13   ` Andrew Morton
2006-12-11  9:21     ` Al Viro
2006-12-11  9:25       ` Andrew Morton
2006-12-11  9:33         ` Al Viro
2006-12-11  9:47           ` Andrew Morton
2006-12-11 10:03             ` Al Viro
2006-12-11 10:17               ` Andrew Morton
2006-12-11 10:22                 ` Al Viro
2006-12-11 10:34                   ` Andrew Morton
2006-12-11 10:47                     ` Al Viro
2006-12-11 10:57                     ` Jeff Garzik
2006-12-11 10:27                 ` Andrew Morton
2006-12-11 10:45                   ` Al Viro
2006-12-11 16:01                     ` Linus Torvalds
2006-12-11 16:12                       ` Al Viro
2006-12-11 16:40                         ` Linus Torvalds
2006-12-12  0:33                           ` Benjamin Herrenschmidt
2006-12-12  2:08                       ` Andrew Morton
2006-12-12  2:17                         ` Dominik Brodowski [this message]
2006-12-12  2:23                         ` Linus Torvalds
2006-12-11 10:52                 ` [PATCH] get rid of ARCH_HAVE_XTIME_LOCK Eric Dumazet
2006-12-11 13:50                   ` [PATCH] Optimize calc_load() Eric Dumazet
2006-12-11 19:04                     ` [PATCH] constify pipe_buf_operations Eric Dumazet
2006-12-11  9:13 ` [patch] pipe: Don't oops when pipe filesystem isn't mounted Al Viro
2006-12-11  9:40   ` Michael Tokarev
2006-12-11 15:44 ` Linus Torvalds
2006-12-12 12:20   ` Michael Tokarev
2006-12-11  9:33 Chuck Ebbert
2006-12-11 10:48 ` Olaf Hering
2006-12-11 10:52   ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061212021742.GA2820@isilmar.linta.de \
    --to=linux@dominikbrodowski.net \
    --cc=76306.1226@compuserve.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®