From: Dirk Eibach <eibach@gdsys.de>
To: linux-usb-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] usblp: Add serial number to device ID
Date: Tue, 12 Dec 2006 16:00:23 +0100 [thread overview]
Message-ID: <20061212160023.2b96f091.eibach@gdsys.de> (raw)
I noticed that some USB-printers, e.g. Canon PIXMA iP3000 don't add
their serial number to the IEEE-1284 device ID string as expected by
userspace apps like cups.
Because of this, connecting multiple printers of the same type to a
system does not work properly.
This patch adds the usb serial number to the device ID if it is left
out by the printer.
This patch applies to kernel 2.6.18.
Signed-off-by: Dirk Eibach <eibach@gdsys.de>
---
--- a/drivers/usb/class/usblp.c 2006-09-20 05:42:06.000000000 +0200
+++ b/drivers/usb/class/usblp.c 2006-12-12 15:27:23.000000000 +0100
@@ -1134,6 +1134,18 @@ static int usblp_cache_device_id_string(
length = USBLP_DEVICE_ID_SIZE - 1;
usblp->device_id_string[length] = '\0';
+ /* Insert serial number into the device ID string if the printer
+ * is braindead enough to leave it out. */
+ if ( (usblp->dev->serial)
+ && (length + strlen(usblp->dev->serial) + 6 < USBLP_DEVICE_ID_SIZE)
+ && !strstr(usblp->device_id_string+2, "SERN:")
+ && !strstr(usblp->device_id_string+2, "SER:") )
+ {
+ sprintf(usblp->device_id_string+length, "SERN:%s;", usblp->dev->serial);
+ length += 6 + strlen(usblp->dev->serial);
+ *((__be16 *)usblp->device_id_string) = cpu_to_be16(length);
+ }
+
dbg("usblp%d Device ID string [len=%d]=\"%s\"",
usblp->minor, length, &usblp->device_id_string[2]);
reply other threads:[~2006-12-12 15:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061212160023.2b96f091.eibach@gdsys.de \
--to=eibach@gdsys.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®