From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@osdl.org>
Cc: Linus Torvalds <torvalds@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [patch] lockdep: fix seqlock_init()
Date: Tue, 12 Dec 2006 21:50:01 +0100 [thread overview]
Message-ID: <20061212205001.GA31445@elte.hu> (raw)
In-Reply-To: <20061212094820.1049a252.akpm@osdl.org>
* Andrew Morton <akpm@osdl.org> wrote:
> On Tue, 12 Dec 2006 12:10:28 +0100
> Ingo Molnar <mingo@elte.hu> wrote:
>
> > +#define seqlock_init(x) \
> > + do { \
> > + (x)->sequence = 0; \
> > + spin_lock_init(&(x)->lock); \
> > + } while (0)
>
> This does not have to be a macro, does it?
Maybe it could be an __always_inline inline function (it has to be
inlined to get the callsite based lock class key right) - but i'm not
sure about the include file dependencies. Will probably work out fine as
seqlock.h is supposed to be a late one in the order of inclusion - but i
didnt want to make a blind bet.
Ingo
next prev parent reply other threads:[~2006-12-12 20:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-12 11:10 Ingo Molnar
2006-12-12 17:48 ` Andrew Morton
2006-12-12 20:50 ` Ingo Molnar [this message]
2006-12-12 21:06 ` Andrew Morton
2006-12-13 1:15 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061212205001.GA31445@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®