From: Francois Romieu <romieu@fr.zoreil.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Ingo Molnar <mingo@elte.hu>, Linus Torvalds <torvalds@osdl.org>,
Andrew Morton <akpm@osdl.org>,
"David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] net, 8139too.c: fix netpoll deadlock
Date: Tue, 12 Dec 2006 22:49:39 +0100 [thread overview]
Message-ID: <20061212214939.GA470@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <457EAE62.8090404@garzik.org>
Jeff Garzik <jeff@garzik.org> :
> Ingo Molnar wrote:
[...]
> >fix deadlock in the 8139too driver: poll handlers should never forcibly
> >enable local interrupts, because they might be used by netpoll/printk
> >from IRQ context.
>
> ACK
>
> (I'll queue it, if Linus doesn't pick it up; please CC me in the future)
I have lived with the "NAPI ->poll() handler runs in BH irq enabled context"
rule for years. Is it definitely false/dead ?
If so at least 8139cp needs the same fix.
--
Ueimor
next prev parent reply other threads:[~2006-12-12 21:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-12 10:16 [patch] netpoll: fix netpoll lockups Ingo Molnar
2006-12-12 12:49 ` [patch] net, 8139too.c: fix netpoll deadlock Ingo Molnar
2006-12-12 13:28 ` Jeff Garzik
2006-12-12 21:49 ` Francois Romieu [this message]
2006-12-13 1:12 ` Ingo Molnar
2007-02-14 2:30 ` Atsushi Nemoto
2007-02-16 4:33 ` Atsushi Nemoto
2006-12-12 16:13 ` [patch] netpoll: fix netpoll lockups Linus Torvalds
2006-12-12 16:20 ` [patch] netpoll: fix netpoll lockup Ingo Molnar
2006-12-12 21:00 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061212214939.GA470@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®