From: Paul Jackson <pj@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Paul Jackson <pj@sgi.com>,
linux-kernel@vger.kernel.org,
Christoph Lameter <clameter@sgi.com>
Subject: [PATCH] CONFIG_VM_EVENT_COUNTER comment decrustify
Date: Wed, 13 Dec 2006 10:19:56 -0800 [thread overview]
Message-ID: <20061213181956.6440.15235.sendpatchset@jackhammer.engr.sgi.com> (raw)
From: Paul Jackson <pj@sgi.com>
The VM event counters, enabled by CONFIG_VM_EVENT_COUNTERS,
which provides VM event counters in /proc/vmstat, has become
more essential to non-EMBEDDED kernel configurations than they
were in the past. Comments in the code and the Kconfig configuration
explanation were stale, downplaying their role excessively.
Refresh those comments to correctly reflect the current role of
VM event counters.
Signed-off-by: Paul Jackson <pj@sgi.com>
---
Christoph and Andrew (I sure hope) understand what's the truth
here better than I. I trust they won't hesitate to refine,
hack, mutilate, ignore or extend this patch, as appropriate.
- pj
include/linux/vmstat.h | 5 +++--
init/Kconfig | 8 ++++----
2 files changed, 7 insertions(+), 6 deletions(-)
--- 2.6.19-mm1.orig/include/linux/vmstat.h 2006-12-12 04:12:59.850645800 -0800
+++ 2.6.19-mm1/include/linux/vmstat.h 2006-12-13 10:02:31.205199749 -0800
@@ -10,8 +10,9 @@
/*
* Light weight per cpu counter implementation.
*
- * Counters should only be incremented and no critical kernel component
- * should rely on the counter values.
+ * Counters should only be incremented. You need to set EMBEDDED
+ * to disable VM_EVENT_COUNTERS. Things like procps (vmstat,
+ * top, etc) use /proc/vmstat and depend on these counters.
*
* Counters are handled completely inline. On many platforms the code
* generated will simply be the increment of a global address.
--- 2.6.19-mm1.orig/init/Kconfig 2006-12-12 04:12:59.994647698 -0800
+++ 2.6.19-mm1/init/Kconfig 2006-12-13 10:12:17.424473564 -0800
@@ -483,10 +483,10 @@ config VM_EVENT_COUNTERS
default y
bool "Enable VM event counters for /proc/vmstat" if EMBEDDED
help
- VM event counters are only needed to for event counts to be
- shown. They have no function for the kernel itself. This
- option allows the disabling of the VM event counters.
- /proc/vmstat will only show page counts.
+ VM event counters are needed for event counts to be shown.
+ This option allows the disabling of the VM event counters
+ on EMBEDDED systems. /proc/vmstat will only show page counts
+ if VM event counters are disabled.
endmenu # General setup
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.650.933.1373
next reply other threads:[~2006-12-13 19:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-13 18:19 Paul Jackson [this message]
2006-12-13 18:31 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061213181956.6440.15235.sendpatchset@jackhammer.engr.sgi.com \
--to=pj@sgi.com \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®