From: Alan <alan@lxorguk.ukuu.org.uk>
To: Doug Thompson <norsk5@yahoo.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] EDAC: Add Fully-Buffered DIMM APIs to core
Date: Thu, 14 Dec 2006 10:58:09 +0000 [thread overview]
Message-ID: <20061214105809.4143be6c@localhost.localdomain> (raw)
In-Reply-To: <236399.13106.qm@web50113.mail.yahoo.com>
> +void edac_mc_handle_fbd_ue(struct mem_ctl_info *mci,
> + unsigned int csrow,
> + unsigned int channela,
> + unsigned int channelb,
> + char *msg)
> +{
> + int len = EDAC_MC_LABEL_LEN * 4;
> + char labels[len + 1];
Have you checked gcc generates the right code from this and not a dynamic
allocation. I'm not sure if you want "const int len" to force that ?
Otherwise looks ok
next prev parent reply other threads:[~2006-12-14 10:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-14 1:19 Doug Thompson
2006-12-14 10:58 ` Alan [this message]
2006-12-14 21:01 ` Andrew Morton
2006-12-14 21:13 ` Doug Thompson
2006-12-14 21:05 ` Doug Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061214105809.4143be6c@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=norsk5@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome