From: Randy Dunlap <randy.dunlap@oracle.com>
To: "Zack Weinberg" <zackw@panix.com>
Cc: "Stephen Smalley" <sds@tycho.nsa.gov>,
jmorris@namei.org, "Chris Wright" <chrisw@sous-sol.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 2/4] permission mapping for sys_syslog operations
Date: Fri, 15 Dec 2006 09:08:43 -0800 [thread overview]
Message-ID: <20061215090843.3bff4ab9.randy.dunlap@oracle.com> (raw)
In-Reply-To: <eb97335b0612141721g2e983574k4ea698caa316de6d@mail.gmail.com>
On Thu, 14 Dec 2006 17:21:25 -0800 Zack Weinberg wrote:
> On 12/14/06, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > > +#define security_syslog_or_fail(type) do { \
> > > + int error = security_syslog(type); \
> > > + if (error) \
> > > + return error; \
> > > + } while (0)
> > > +
> >
> > From Documentation/CodingStyle:
> >
> > Things to avoid when using macros:
> >
> > 1) macros that affect control flow: ...
>
> It says "avoid", not "never use". If you can think of another way to
> code this function that won't completely obscure the actual operations
> with the security checks, I will be happy to change it.
The usual answer is to just open-code it. You may dislike that,
but hiding control flow in macros is held as really bad by
more than just me.
---
~Randy
next prev parent reply other threads:[~2006-12-15 17:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-15 0:16 [patch 0/4] /proc/kmsg permissions, take three Zack Weinberg
2006-12-15 0:16 ` [patch 1/4] Add <linux/klog.h> Zack Weinberg
2006-12-15 0:59 ` Randy Dunlap
2006-12-15 1:21 ` Zack Weinberg
2006-12-15 0:16 ` [patch 2/4] permission mapping for sys_syslog operations Zack Weinberg
2006-12-15 1:02 ` Randy Dunlap
2006-12-15 1:21 ` Zack Weinberg
2006-12-15 17:08 ` Randy Dunlap [this message]
2006-12-15 0:16 ` [patch 3/4] Refactor do_syslog interface Zack Weinberg
2006-12-15 0:16 ` [patch 4/4] Distinguish /proc/kmsg access from sys_syslog Zack Weinberg
-- strict thread matches above, loose matches on Subject: below --
2006-12-24 20:22 [patch 0/4] /proc/kmsg permissions, take four Zack Weinberg
2006-12-24 20:22 ` [patch 2/4] permission mapping for sys_syslog operations Zack Weinberg
2006-11-13 6:40 [patch 0/4] Syslog permissions, revised Zack Weinberg
2006-11-13 6:40 ` [patch 2/4] permission mapping for sys_syslog operations Zack Weinberg
2006-11-13 9:25 ` Arjan van de Ven
2006-11-13 9:29 ` Zack Weinberg
2006-11-13 9:47 ` Arjan van de Ven
2006-11-13 17:17 ` Zack Weinberg
2006-11-13 17:22 ` Arjan van de Ven
2006-11-13 21:13 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061215090843.3bff4ab9.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=chrisw@sous-sol.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®