mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@sous-sol.org>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: akpm@osdl.org, "Theodore Ts'o" <tytso@mit.edu>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	Justin Forbes <jmforbes@linuxtx.org>,
	torvalds@osdl.org, Chris Wedgwood <reviews@ml.cw.f00f.org>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Michael Krufky <mkrufky@linuxtv.org>,
	Dave Jones <davej@redhat.com>,
	Chuck Wolber <chuckw@quantumlinux.com>,
	alan@lxorguk.ukuu.org.uk,
	Arjan van de Ven <arjan@linux.intel.com>, Andi Kleen <ak@suse.de>
Subject: [patch 25/24] x86-64: Mark rdtsc as sync only for netburst, not for core2
Date: Fri, 15 Dec 2006 10:20:39 -0800	[thread overview]
Message-ID: <20061215182039.GG10475@sequoia.sous-sol.org> (raw)
In-Reply-To: <20061215013337.823935000@sous-sol.org>

2.6.18-stable review patch.  If anyone has any objections, please let us know.  
------------------  

From: Arjan van de Ven <arjan@linux.intel.com>

On the Core2 cpus, the rdtsc instruction is not serializing (as defined
in the architecture reference since rdtsc exists) and due to the deep
speculation of these cores, it's possible that you can observe time go
backwards between cores due to this speculation. Since the kernel
already deals with this with the SYNC_RDTSC flag, the solution is
simple, only assume that the instruction is serializing on family 15...

The price one pays for this is a slightly slower gettimeofday (by a
dozen or two cycles), but that increase is quite small to pay for a
really-going-forward tsc counter.

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Andi Kleen <ak@suse.de>
[chrisw: backported to 2.6.18]
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
---
Commit:     f3d73707a1e84f0687a05144b70b660441e999c7
Author:     Arjan van de Ven <arjan@linux.intel.com>
Date:       Thu Dec 7 02:14:12 2006 +0100

 arch/x86_64/kernel/setup.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

--- linux-2.6.18.5.orig/arch/x86_64/kernel/setup.c
+++ linux-2.6.18.5/arch/x86_64/kernel/setup.c
@@ -1010,7 +1010,10 @@ static void __cpuinit init_intel(struct 
 	if ((c->x86 == 0xf && c->x86_model >= 0x03) ||
 	    (c->x86 == 0x6 && c->x86_model >= 0x0e))
 		set_bit(X86_FEATURE_CONSTANT_TSC, &c->x86_capability);
-	set_bit(X86_FEATURE_SYNC_RDTSC, &c->x86_capability);
+	if (c->x86 == 15)
+		set_bit(X86_FEATURE_SYNC_RDTSC, &c->x86_capability);
+	else
+		clear_bit(X86_FEATURE_SYNC_RDTSC, &c->x86_capability);
  	c->x86_max_cores = intel_num_cpu_cores(c);
 
 	srat_detect_node();

      parent reply	other threads:[~2006-12-15 18:19 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-15  1:33 [patch 00/24] -stable review Chris Wright
2006-12-15  1:33 ` [patch 01/24] softmac: remove netif_tx_disable when scanning Chris Wright
2006-12-15  1:33 ` [patch 02/24] EBTABLES: Fix wraparounds in ebt_entries verification Chris Wright
2006-12-15  1:33 ` [patch 03/24] EBTABLES: Verify that ebt_entries have zero ->distinguisher Chris Wright
2006-12-15  1:33 ` [patch 04/24] EBTABLES: Deal with the worst-case behaviour in loop checks Chris Wright
2006-12-15  1:33 ` [patch 05/24] EBTABLES: Prevent wraparounds in checks for entry components sizes Chris Wright
2006-12-15  1:33 ` [patch 06/24] NET_SCHED: policer: restore compatibility with old iproute binaries Chris Wright
2006-12-15  1:33 ` [patch 07/24] dm crypt: Fix data corruption with dm-crypt over RAID5 Chris Wright
2006-12-15  1:33 ` [patch 08/24] NETFILTER: ip_tables: revision support for compat code Chris Wright
2006-12-15  1:33 ` [patch 09/24] PKT_SCHED act_gact: division by zero Chris Wright
2006-12-15  1:33 ` [patch 10/24] SUNHME: Fix for sunhme failures on x86 Chris Wright
2006-12-15  1:33 ` [patch 11/24] XFRM: Use output device disable_xfrm for forwarded packets Chris Wright
2006-12-15  1:33 ` [patch 12/24] dm snapshot: fix freeing pending exception Chris Wright
2006-12-15  1:33 ` [patch 13/24] IPSEC: Fix inetpeer leak in ipv4 xfrm dst entries Chris Wright
2006-12-15  1:33 ` [patch 14/24] IrDA: Incorrect TTP header reservation Chris Wright
2006-12-15  1:33 ` [patch 15/24] bonding: incorrect bonding state reported via ioctl Chris Wright
2006-12-15  1:33 ` [patch 16/24] DVB: lgdt330x: fix signal / lock status detection bug Chris Wright
2006-12-15  1:33 ` [patch 17/24] V4L: Fix broken TUNER_LG_NTSC_TAPE radio support Chris Wright
2006-12-15  1:33 ` [patch 18/24] ieee1394: ohci1394: add PPC_PMAC platform code to driver probe Chris Wright
2006-12-15  1:33 ` [patch 19/24] ARM: Add sys_*at syscalls Chris Wright
2006-12-15  1:33 ` [patch 20/24] skip data conversion in compat_sys_mount when data_page is NULL Chris Wright
2006-12-15  1:33 ` [patch 21/24] softirq: remove BUG_ONs which can incorrectly trigger Chris Wright
2006-12-15  1:33 ` [patch 22/24] m32r: make userspace headers platform-independent Chris Wright
2006-12-15  1:34 ` [patch 23/24] forcedeth: Disable INTx when enabling MSI in forcedeth Chris Wright
2006-12-15  1:34 ` [patch 24/24] Bluetooth: Add packet size checks for CAPI messages (CVE-2006-6106) Chris Wright
2006-12-15  1:37 ` [patch 00/24] -stable review Chris Wright
2006-12-15 18:20 ` Chris Wright [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061215182039.GG10475@sequoia.sous-sol.org \
    --to=chrisw@sous-sol.org \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=arjan@linux.intel.com \
    --cc=chuckw@quantumlinux.com \
    --cc=davej@redhat.com \
    --cc=jmforbes@linuxtx.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkrufky@linuxtv.org \
    --cc=rdunlap@xenotime.net \
    --cc=reviews@ml.cw.f00f.org \
    --cc=stable@kernel.org \
    --cc=torvalds@osdl.org \
    --cc=tytso@mit.edu \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®