From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965064AbWLOVOq (ORCPT ); Fri, 15 Dec 2006 16:14:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965068AbWLOVOq (ORCPT ); Fri, 15 Dec 2006 16:14:46 -0500 Received: from caramon.arm.linux.org.uk ([217.147.92.249]:4417 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965064AbWLOVOp (ORCPT ); Fri, 15 Dec 2006 16:14:45 -0500 Date: Fri, 15 Dec 2006 21:14:35 +0000 From: Russell King To: Lennert Buytenhek Cc: Francois Romieu , Martin Michlmayr , Riku Voipio , linux-kernel@vger.kernel.org Subject: Re: r8169 on n2100 (was Re: r8169 mac address change (was Re: [0/3] 2.6.19-rc2: known regressions)) Message-ID: <20061215211435.GB10367@flint.arm.linux.org.uk> Mail-Followup-To: Lennert Buytenhek , Francois Romieu , Martin Michlmayr , Riku Voipio , linux-kernel@vger.kernel.org References: <20061108203546.GA32247@kos.to> <20061109221338.GA17722@electric-eye.fr.zoreil.com> <20061109231408.GB6611@xi.wantstofly.org> <20061110185937.GA9665@electric-eye.fr.zoreil.com> <20061121102458.GA7846@deprecation.cyrius.com> <20061121204527.GA13549@electric-eye.fr.zoreil.com> <20061122231656.GA9991@electric-eye.fr.zoreil.com> <20061215132740.GD11579@xi.wantstofly.org> <20061215201522.GA11288@electric-eye.fr.zoreil.com> <20061215210329.GB14860@xi.wantstofly.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061215210329.GB14860@xi.wantstofly.org> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 15, 2006 at 10:03:29PM +0100, Lennert Buytenhek wrote: > On Fri, Dec 15, 2006 at 09:15:22PM +0100, Francois Romieu wrote: > > > > Is there a way we can have this done by default on the n2100? I guess > > > that since it's a PCI device, there isn't much hope for that..? > > > > Do you mean an automagically tuned default value based on CONFIG_ARM ? > > No, that wouldn't make sense, that's like making a workaround depend on > arch == i386. > > I'm thinking that we should somehow enable this option on the n2100 > built-in r8169 ports by default only. Since the n2100 also has a mini-PCI > slot, and it is in theory possible to put an r8169 on a mini-PCI card, > the workaround probably shouldn't apply to those, so testing for > CONFIG_MACH_N2100 also isn't the right thing to do. There is dev->broken_parity_status ... although exactly what the sematics of that flag actually are seems to be rather vague - there's code which sets it for the Mellanox Tavor device, but it seems to only be exposed via sysfs - no code in drivers/pci seems to take any action based upon this flag being set. That rather raises the question about the usefulness of that quirk. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: