From: "Jörn Engel" <joern@lazybastard.org>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Pavel Machek <pavel@ucw.cz>, Scott Preece <sepreece@gmail.com>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH/v2] CodingStyle updates
Date: Fri, 15 Dec 2006 21:27:24 +0000 [thread overview]
Message-ID: <20061215212724.GB317@lazybastard.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0612152158240.28506@yvahk01.tjqt.qr>
On Fri, 15 December 2006 22:01:10 +0100, Jan Engelhardt wrote:
> On Dec 15 2006 15:56, Dmitry Torokhov wrote:
> >
> > Would you write:
> >
> > i+=2;
> >
> > outside the loop? If not then it is better to keep style consistent
> > and not use condensed form in loops either.
>
> Don't you all even think about leaving the whitespace away in the wrong
> place, otherwise the kernel is likely to become an entry for IOCCC.
Please, this is not religion. No god has spoken "though shalt not...".
In 99% of all cases, what Randy wrote is the best choice. But the
ultimate goal is not to follow his heavenly rules with fundamental
zealotry, the ultimate goal is to make the code readable. If you
happen to stumble on the 1% case where the code can be more readable by
not following the rules, and you are absolutely sure about that, then
don't. That simple. ;)
That said, people who are bereft of all common sense have my blessing to
follow the rules literally in their own code. Just don't stomp over
mine with pitchforks and torches, ok?
Jörn
--
I can say that I spend most of my time fixing bugs even if I have lots
of new features to implement in mind, but I give bugs more priority.
-- Andrea Arcangeli, 2000
next prev parent reply other threads:[~2006-12-15 21:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 0:55 Randy Dunlap
2006-12-08 11:04 ` Jan Engelhardt
2006-12-15 12:09 ` Pavel Machek
2006-12-15 14:18 ` Stefan Richter
2006-12-15 14:22 ` Pavel Machek
2006-12-15 14:28 ` Stefan Richter
2006-12-15 17:06 ` Jan Engelhardt
2006-12-15 17:13 ` Randy Dunlap
2006-12-15 14:52 ` Scott Preece
2006-12-15 15:04 ` Stefan Richter
2006-12-15 15:07 ` Pavel Machek
2006-12-15 16:16 ` Scott Preece
2006-12-15 17:00 ` Randy Dunlap
2006-12-15 20:11 ` Jörn Engel
2006-12-15 20:26 ` Randy Dunlap
2006-12-15 21:10 ` Jörn Engel
2006-12-15 21:16 ` Jörn Engel
2006-12-15 21:25 ` Randy Dunlap
2006-12-15 20:56 ` Dmitry Torokhov
2006-12-15 21:01 ` Jan Engelhardt
2006-12-15 21:27 ` Jörn Engel [this message]
2006-12-15 21:59 ` Jan Engelhardt
2006-12-19 18:46 ` 2.6.20-rc1-mm1 suspicious prececence code ( was " Valdis.Kletnieks
2006-12-15 20:30 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061215212724.GB317@lazybastard.org \
--to=joern@lazybastard.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=randy.dunlap@oracle.com \
--cc=sepreece@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®