From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [patch] workqueue: fix drivers/connector/connector.c
Date: Tue, 19 Dec 2006 22:31:34 +0100 [thread overview]
Message-ID: <20061219213134.GA16619@elte.hu> (raw)
Subject: [patch] workqueue: fix drivers/connector/connector.c
From: Ingo Molnar <mingo@elte.hu>
commit c4028958b6ecad064b1a6303a6a5906d4fe48d73 did an incorrect
conversion of the work-pending check in the connector device (which
device is enabled in the -rt kernel rpm) - fix this by using
work_pending().
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
drivers/connector/connector.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Index: linux/drivers/connector/connector.c
===================================================================
--- linux.orig/drivers/connector/connector.c
+++ linux/drivers/connector/connector.c
@@ -135,8 +135,7 @@ static int cn_call_callback(struct cn_ms
spin_lock_bh(&dev->cbdev->queue_lock);
list_for_each_entry(__cbq, &dev->cbdev->queue_list, callback_entry) {
if (cn_cb_equal(&__cbq->id.id, &msg->id)) {
- if (likely(!test_bit(WORK_STRUCT_PENDING,
- &__cbq->work.work.management) &&
+ if (likely(!work_pending(&__cbq->work.work) &&
__cbq->data.ddata == NULL)) {
__cbq->data.callback_priv = msg;
reply other threads:[~2006-12-19 21:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061219213134.GA16619@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome