From: "Sébastien Dugué" <sebastien.dugue@bull.net>
To: "Pekka Enberg" <penberg@cs.helsinki.fi>
Cc: "Linus Torvalds" <torvalds@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Jean Pierre Dion" <jean-pierre.dion@bull.net>
Subject: Re: Fix IPMI watchdog set_param_str() using kstrdup
Date: Wed, 20 Dec 2006 12:32:07 +0100 [thread overview]
Message-ID: <20061220123207.4b48af02@frecb000686> (raw)
In-Reply-To: <84144f020612200319s748457ccr11f527dd7bca4c96@mail.gmail.com>
On Wed, 20 Dec 2006 13:19:09 +0200 "Pekka Enberg" <penberg@cs.helsinki.fi> wrote:
> On 12/20/06, Sébastien Dugué <sebastien.dugue@bull.net> wrote:
> > set_param_str() cannot use kstrdup() to duplicate the parameter. That's
> > fine when the driver is compiled as a module but it sure is not when
> > built into the kernel as the kernel parameters are parsed before the
> > kmalloc slabs are setup.
>
> Aah. I wonder though, if we could defer parsing driver parameters
> until kmalloc caches are up...
From a general point of view, why not. Except that for the
watchdog case, I want it to start as soon as possible for it to be
able to reboot in case of an early crash.
Sébastien.
prev parent reply other threads:[~2006-12-20 11:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-20 11:05 Sébastien Dugué
2006-12-20 11:19 ` Pekka Enberg
2006-12-20 11:32 ` Sébastien Dugué [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061220123207.4b48af02@frecb000686 \
--to=sebastien.dugue@bull.net \
--cc=jean-pierre.dion@bull.net \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®