mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Miguel Ojeda Sandonis <maxextreme@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH update9] drivers: add LCD support
Date: Wed, 20 Dec 2006 23:18:19 -0800	[thread overview]
Message-ID: <20061220231819.185c5236.akpm@osdl.org> (raw)
In-Reply-To: <20061220151000.27602c37.maxextreme@gmail.com>

On Wed, 20 Dec 2006 15:10:00 +0100
Miguel Ojeda Sandonis <maxextreme@gmail.com> wrote:

> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -65,6 +65,7 @@ config KS0108_DELAY
>  config CFAG12864B
>         tristate "CFAG12864B LCD"
>         depends on X86
> +       depends on FB
>         depends on KS0108
>         default n
>         ---help---
> @@ -74,6 +75,8 @@ config CFAG12864B
>           For help about how to wire your LCD to the parallel port,
>           check Documentation/auxdisplay/cfag12864b
> 
> +         Depends on the x86 arch and the framebuffer support.

heh, that was clever.

scripts/kconfig/conf -m arch/i386/Kconfig
drivers/auxdisplay/Kconfig:81:warning: multi-line strings not supported
drivers/auxdisplay/Kconfig:78: unknown option "Depends"
drivers/auxdisplay/Kconfig:80: unknown option "The"
drivers/auxdisplay/Kconfig:81: unknown option "It"
drivers/auxdisplay/Kconfig:82: unknown option "of"
drivers/auxdisplay/Kconfig:84: unknown option "To"
drivers/auxdisplay/Kconfig:85: unknown option "the"
drivers/auxdisplay/Kconfig:87: unknown option "If"
make[1]: *** [allmodconfig] Error 1

you broke Roman's parser.


Oh, your patch used spaces where tabs should have been.  Please don't do
that.


      parent reply	other threads:[~2006-12-21  7:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-20 14:10 Miguel Ojeda Sandonis
2006-12-21  5:13 ` Andrew Morton
2006-12-22 12:34   ` Miguel Ojeda
2006-12-21  7:18 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061220231819.185c5236.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxextreme@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®