Re: [patch] mm: export cancel_dirty_page()

[Ingo Molnar <mingo@elte.hu>]

* Adrian Bunk <bunk@stusta.de> wrote:

> On Fri, Dec 22, 2006 at 12:13:28AM +0100, Ingo Molnar wrote:
> > From: Ingo Molnar <mingo@elte.hu>
> > Subject: [patch] export cancel_dirty_page()
> > 
> > export cancel_dirty_page() - it's used by hugetlbfs which can be 
> > modular. (This makes my -git based kernel yum repository build again.)
> >...
> 
> No, it can't be:
> 
> config HUGETLBFS
>         bool "HugeTLB file system support"
>         ^^^^

ah, indeed - but i dont see a fundamental reason why hugetlbfs is not 
modular. Nevertheless exporting this makes sense. My quick hack below to 
guess to convert reiserfs (just to make the rpm build) also needs it.

	Ingo

Index: linux/fs/reiserfs/stree.c
===================================================================
--- linux.orig/fs/reiserfs/stree.c
+++ linux/fs/reiserfs/stree.c
@@ -1439,6 +1439,8 @@ static void unmap_buffers(struct page *p
 
 	if (page) {
 		if (page_has_buffers(page)) {
+			cancel_dirty_page(page, PAGE_CACHE_SIZE);
+
 			tail_index = pos & (PAGE_CACHE_SIZE - 1);
 			cur_index = 0;
 			head = page_buffers(page);
@@ -1458,9 +1460,6 @@ static void unmap_buffers(struct page *p
 				}
 				bh = next;
 			} while (bh != head);
-			if (PAGE_SIZE == bh->b_size) {
-				clear_page_dirty(page);
-			}
 		}
 	}
 }