From: Christoph Hellwig <hch@infradead.org>
To: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>
Cc: jens.axboe@oracle.com, agk@redhat.com, mchristi@redhat.com,
linux-kernel@vger.kernel.org, dm-devel@redhat.com,
j-nomura@ce.jp.nec.com
Subject: Re: [RFC PATCH 1/8] rqbased-dm: allow blk_get_request() to be called from interrupt context
Date: Fri, 22 Dec 2006 14:01:39 +0000 [thread overview]
Message-ID: <20061222140139.GA26033@infradead.org> (raw)
In-Reply-To: <20061220.125002.71083198.k-ueda@ct.jp.nec.com>
On Wed, Dec 20, 2006 at 12:50:02PM -0500, Kiyoshi Ueda wrote:
> Because I'd like to use blk_get_request() in q->request_fn()
> which can be called from interrupt context like below:
> scsi_io_completion -> scsi_end_request -> scsi_next_command
> -> scsi_run_queue -> blk_run_queue -> q->request_fn
> Or request should not be allocated in q->request_fn() anyway?
> Do you have any other ideas?
The right long-term fix is to make sure request_fn is only ever called
from process context. This means moving retry handling to a thread instead
of a softirq, but this will need careful performance testing and tweaking.
next prev parent reply other threads:[~2006-12-22 14:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-19 22:11 Kiyoshi Ueda
2006-12-20 13:48 ` Jens Axboe
2006-12-20 17:50 ` Kiyoshi Ueda
2006-12-20 18:49 ` Jens Axboe
2006-12-20 21:55 ` Kiyoshi Ueda
2006-12-21 7:53 ` Jens Axboe
2006-12-21 17:59 ` [dm-devel] " Mike Christie
2006-12-21 18:13 ` Mike Christie
2006-12-21 18:24 ` Jens Axboe
2006-12-21 18:30 ` Mike Christie
2006-12-21 18:36 ` Mike Christie
2006-12-21 18:42 ` Jens Axboe
2006-12-21 18:57 ` Mike Christie
2006-12-21 19:19 ` Jens Axboe
2006-12-21 22:22 ` Mike Christie
2006-12-21 18:40 ` Jens Axboe
2006-12-21 18:11 ` Kiyoshi Ueda
2006-12-21 18:21 ` Jens Axboe
2006-12-20 19:11 ` Chen, Kenneth W
2006-12-20 19:17 ` Jens Axboe
2006-12-22 14:01 ` Christoph Hellwig [this message]
2006-12-22 17:32 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061222140139.GA26033@infradead.org \
--to=hch@infradead.org \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=jens.axboe@oracle.com \
--cc=k-ueda@ct.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchristi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®