From: Ingo Molnar <mingo@elte.hu>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Fabio Comolli <fabio.comolli@gmail.com>,
kernel list <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: [patch] sched: remove __resched_legal() and fix cond_resched_softirq()
Date: Wed, 27 Dec 2006 12:16:19 +0100 [thread overview]
Message-ID: <20061227111619.GA12234@elte.hu> (raw)
In-Reply-To: <87ac19epqr.fsf@duaron.myhome.or.jp>
* OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> wrote:
> > i found another bug and realized that the whole __resched_legal()
> > approach is fundamentally wrong! The patch below fixes this.
>
> Hmm.. but the path seems,
>
> -> cond_resched()
> -> if (__resched_legal()) /* preempt_count == 0 */
> -> __cond_resched() /* preempt_count == 0x10000000 */
> -> schedule()
> [...]
> -> cond_resched()
> -> if (__resched_legal()) /* preempt_count == 0x10000000 */
> -> __cond_resched() /* preempt_count == 0x20000000 */
> -> schedule() /* warning */
>
> Where is it prevented? Or warning is just wrong?
this should be handled by the second version of the patch i sent out
yesterday. When we have PREEMPT_ACTIVE set, no schedule() call is legal.
Ingo
prev parent reply other threads:[~2006-12-27 11:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-24 13:53 BUG: scheduling while atomic - Linux 2.6.20-rc2-ga3d89517 Fabio Comolli
2006-12-24 16:58 ` OGAWA Hirofumi
2006-12-25 19:02 ` Fabio Comolli
2006-12-26 17:15 ` Pavel Machek
2006-12-26 17:25 ` Fabio Comolli
2006-12-26 17:27 ` Randy Dunlap
2006-12-26 13:07 ` [patch] sched: remove __resched_legal() and fix cond_resched_softirq() Ingo Molnar
2006-12-27 7:56 ` OGAWA Hirofumi
2006-12-27 11:16 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061227111619.GA12234@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=fabio.comolli@gmail.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®