From: Chuck Ebbert <76306.1226@compuserve.com>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Michael Holzheu <holzheu@de.ibm.com>, linux-kernel@vger.kernel.org
Subject: Re: [S390] cio: fix stsch_reset.
Date: Sun, 31 Dec 2006 01:31:43 -0500 [thread overview]
Message-ID: <200612310135_MC3-1-D6D0-A862@compuserve.com> (raw)
In-Reply-To: <20061228103925.GB6270@skybase>
On Thu, 28 Dec 2006 11:39:25 +0100, Martin Schwidefsky wrote:
> @@ -881,10 +880,18 @@ static void cio_reset_pgm_check_handler(
> static int stsch_reset(struct subchannel_id schid, volatile struct schib *addr)
> {
> int rc;
> + register struct subchannel_id reg1 asm ("1") = schid;
>
> pgm_check_occured = 0;
> s390_reset_pgm_handler = cio_reset_pgm_check_handler;
> - rc = stsch(schid, addr);
> +
> + asm volatile(
> + " stsch 0(%2)\n"
> + " ipm %0\n"
> + " srl %0,28"
> + : "=d" (rc)
> + : "d" (reg1), "a" (addr), "m" (*addr) : "memory", "cc");
> +
> s390_reset_pgm_handler = NULL;
> if (pgm_check_occured)
> return -EIO;
Can't you just put a barrier() before the stsch() call?
--
MBTI: IXTP
next reply other threads:[~2006-12-31 6:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-31 6:31 Chuck Ebbert [this message]
2006-12-31 12:07 ` Martin Schwidefsky
2006-12-31 12:22 ` Heiko Carstens
2007-01-08 9:54 ` Michael Holzheu
-- strict thread matches above, loose matches on Subject: below --
2006-12-28 10:39 Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612310135_MC3-1-D6D0-A862@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=holzheu@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®