From: Tilman Schmidt <tilman@imap.cc>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>
Cc: <linux-kernel@vger.kernel.org>
Cc: Alan <alan@lxorguk.ukuu.org.uk>
Cc: Hansjoerg Lipp <hjlipp@web.de>
Subject: Re: [PATCH 1/1] Char: tty_wakeup cleanup
Date: Sun, 31 Dec 2006 19:08:12 +0100 [thread overview]
Message-ID: <200612311808.kBVI8Cxk018767@lx1.pxnet.com> (raw)
In-Reply-To: <53003385545127333@wsc.cz>
On Sat, 16 Dec 2006 23:17:00 +0100 (CET), Jiri Slaby wrote:
> tty_wakeup cleanup
>
> - remove wake_up_interruptible(&tty->write_wait) surrounding
> tty_wakup(tty);
> - substitute tty->ldisc.write_wakeup(tty) + wake_up() by tty_wakeup(tty);
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Acked-by: Tilman Schmidt <tilman@imap.cc>
(for drivers/isdn/gigaset/interface.c)
> ---
> commit 2acac8f970a75a3dc8466781845ae5d14c3d8988
> tree 396cc84d4e198d2a65cd4aa9748aabeab5681ba5
> parent 8b380d8b1c3ff7d09d68d467d2f135774cab4086
> author Jiri Slaby <jirislaby@gmail.com> Sat, 16 Dec 2006 22:22:57 +0059
> committer Jiri Slaby <jirislaby@gmail.com> Sat, 16 Dec 2006 22:22:57 +0059
[...]
> diff --git a/drivers/isdn/gigaset/interface.c b/drivers/isdn/gigaset/interface.c
> index 458b646..f13de20 100644
> --- a/drivers/isdn/gigaset/interface.c
> +++ b/drivers/isdn/gigaset/interface.c
> @@ -599,19 +599,9 @@ out:
> static void if_wake(unsigned long data)
> {
> struct cardstate *cs = (struct cardstate *) data;
> - struct tty_struct *tty;
> -
> - tty = cs->tty;
> - if (!tty)
> - return;
> -
> - if ((tty->flags & (1 << TTY_DO_WRITE_WAKEUP)) &&
> - tty->ldisc.write_wakeup) {
> - gig_dbg(DEBUG_IF, "write wakeup call");
> - tty->ldisc.write_wakeup(tty);
> - }
>
> - wake_up_interruptible(&tty->write_wait);
> + if (cs->tty)
> + tty_wakeup(cs->tty);
> }
>
> /*** interface to common ***/
prev parent reply other threads:[~2006-12-31 18:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-16 22:17 Jiri Slaby
2006-12-31 18:08 ` Tilman Schmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612311808.kBVI8Cxk018767@lx1.pxnet.com \
--to=tilman@imap.cc \
--cc=akpm@osdl.org \
--cc=jirislaby@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®