From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0ED23C2763 for ; Mon, 30 Mar 2026 11:23:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869836; cv=none; b=GyfwvBVGOf+LNZc/NQgjgaDAzfUsIwo881DSM2732fx0sgHqIjValTjozso8Czw8JvhxxxiP9IxBx07vgK0KdvFHOARtSMrGxT+ykpNlukjHBoXNFHL8mTF05WdgTFIXb5koAGyO840atIili0ECFS4bFAQdh1x0JRnblVUBvwQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869836; c=relaxed/simple; bh=XNSFdpfM2bR32VIL/Pg72BqKpzv1k5qHNf3X+rW3gcM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z1lABa2equM29SlJAsjcEJ90GAEFeZqODq/NIULdOmTRZUFxpaycLgclxkSiq7g8ZhIFRpGi0AZMAIYHsuAwT0kf011e3I4CSsCWCd86olcPrL9J7L1DoUdHCx8tGwOm0q9V3E6vrRzX9dR07gcvu7BsrIBI37YJ75qyZ/aWnGk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=k22DrDpp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=j0e3V0bY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="k22DrDpp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="j0e3V0bY" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UBEFG41402726 for ; Mon, 30 Mar 2026 11:23:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /B/dlQtYbpnYFICsQED7Vf8n3G5q0NzZv4+0ckMoCzc=; b=k22DrDpp6dykv5Um 6eVOK9Ohrszxsb9mAphHmQ73KOyjP2+fQoqqQDW614ch/+9W/B2IrtE0EP98kFYw q+NL7yaay59gqCdS5CBz4UUNc2t+cQgHWyS1HJEsL4xHVk/D4jr1c+pYelKhN2ZO QTftm/qbf6DSRGwby+1HO+Nb1Jyzk5Yem3VBfZ37sFfPEzU0VTzDfqt/bUbVuG5p yDCaxJ9tPq+1MZBGa1glC5yiallFr5H0IuVOq+zsRbSxPNdHPCU07mRZ6QH0Ryo/ u4hVXevpDaDAO3OWe4neb7VIi9A2i2BeqIeeejV5O3KoWPxvv2hTiKarttlQdq2Y zPeP8Q== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d7r4h815q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2026 11:23:52 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-35d99c2908cso1916478a91.0 for ; Mon, 30 Mar 2026 04:23:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774869832; x=1775474632; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/B/dlQtYbpnYFICsQED7Vf8n3G5q0NzZv4+0ckMoCzc=; b=j0e3V0bYUVn/Qji5ER54kJDydi1uTO+OCOEAvkp6BmjbaQ7oeIZsrF7Nu2dXP6Xl0e TDimJi3Fz+HICBV7drYlpaL7Dpru1KZWa01jioUPL/u70umTaf+SMoME/0Kmo4yHQnCi sHNdlHnygLPVTRgv+K+SiVLcpKka4wcwaRsEqGHT/rSiEqq6GK7Ar5uOHEweeGENczUZ sjCaYyMMiSAM6ppamZmQv+cqwaSbXOkhkKuKCm+aywH+/vwj/mE4+ijUzMBgUBHq0TH0 a32irDW13XWSQEhRIy1tzX0slTddPsdvEus778c1Hhm4aTUcJl6Alj1+fZ30z6DwlIxU oqcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774869832; x=1775474632; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/B/dlQtYbpnYFICsQED7Vf8n3G5q0NzZv4+0ckMoCzc=; b=mEQL6JgQq9IGadaH7Iftd9PfaoDRwH7e7omdTBt80V6jK2SyUToIX9TYPoXIYJjCI3 B2vrHDXqSVBMFqtNWvfXjmXvMgG2C3vTZj2wWAzd83gYp4PIYV0oPJMuCHT3PqBCP7sc H1zYIxHjPdojlzOo7hq8Rn28zli/PW+CI2Ua0KJWyoOmzEaagDByaiFkdYTwKCx0xpDG ueNT2O66wy6pkS9EizQo3AzkggI0cruLWHw6dWJfRm/BFGNHmvNEDo2vSxl9bziJ1ln/ xujRYQwPwTZmpE8ZujWySin+FTqYsxJ2AaKjfnVr64qC2EMsqTdFOqj6qXQz+jPpajAX /QPQ== X-Forwarded-Encrypted: i=1; AJvYcCX0Lw0CLxPV7qGAhe3+0STQg73EhxxxYCDs8mFw9OmKxRUNOAYbJpHZY9xr7h0FgY4Ir/iknGK+ZBLO0eg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6GMei5Yl8DL0WEp0xEHE5LWHxLMRGxm1F4FpjKZZ1n/leCrYo UqojykKkDR+VAwPFuum6Pj6ASYishzsOoCSimRxNCGxp+ahO+hbQBlAv4Qr2WgDw9/AVm/PTScW LN2/QxVKLZo3PMwZOTauvlDk8lbbzYICQeQj4tWX2pwaqjydLtNCu4D+ejprzC9nPo7U= X-Gm-Gg: ATEYQzx/aZYiY0X784wD8foKcgunfE3eIMe45Rw/BZaqN2FeX9XLPYP9dRk5xnz9DuW ofvWnEEdZm/GLHDYFKpP5H6pbrWTJIw+1sM+Gszr1/jaCHto+2DV1JEFXRVJMuxMLDvXcjsGLMR 86jSYDXgRTRpQoXNNWM/invrGDGzSIpPGDkhbWGoIIKiLCR3+Vba+w+6a3SABd+l7BdKbvPLvs4 bejpGmpRt9EgBJv2SZN5m0fhyr9Olj6JRx9EqHtuQ3A0coM8m0T2ehK2W8Z4Ta8MUSgrapc90hc wC27IFZ9tNTfPOU4eGV9BxA3w0UTiKLxd8Cvb21Cp9OEmkEQYilYEyE5a+J5kT0YFGjOByJNe7L AJQxlJTu2FUm8U6sI7s4VfTS/+gHe3MBi/X6MkRd6JdyisaVAHH37sQ== X-Received: by 2002:a17:90b:3c8a:b0:35b:e4d8:e21d with SMTP id 98e67ed59e1d1-35c2ffb7102mr9816231a91.2.1774869831816; Mon, 30 Mar 2026 04:23:51 -0700 (PDT) X-Received: by 2002:a17:90b:3c8a:b0:35b:e4d8:e21d with SMTP id 98e67ed59e1d1-35c2ffb7102mr9816210a91.2.1774869831315; Mon, 30 Mar 2026 04:23:51 -0700 (PDT) Received: from [10.218.4.221] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c769d8337d3sm3739077a12.8.2026.03.30.04.23.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 04:23:51 -0700 (PDT) Message-ID: <20062190-609a-4977-99be-c27df90ff321@oss.qualcomm.com> Date: Mon, 30 Mar 2026 16:53:45 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/6] arm64: dts: qcom: talos: Add QSPI support To: Konrad Dybcio , Dmitry Baryshkov Cc: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260324-spi-nor-v1-0-3efe59c1c119@oss.qualcomm.com> <20260324-spi-nor-v1-3-3efe59c1c119@oss.qualcomm.com> <34cifkyw3pgky4nhcu4jwf2uveszre23kvesr7ksyjvmqhfspo@avsvwa3quvsp> <9d7c5d36-c981-43ed-a08b-3b75c25fad1e@oss.qualcomm.com> Content-Language: en-US From: Viken Dadhaniya In-Reply-To: <9d7c5d36-c981-43ed-a08b-3b75c25fad1e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA4OSBTYWx0ZWRfXzKchHB/W1pvH VdkRCbn7nVCHVlp2rRSKorzr6MoZA/nS6GM2tRK4BiJ3YToBKjXCe0ytEBuNQ0GezKhF6NXKhVk zKJoeFaptQegSEhJnQSAiGESxw3QU7NMs+gY1P7IeK7n0tFSSHU/lwynNXZ9olK7WKNlfAqylj+ vFuFTBrOcgL/vFI3S0GeruqThdFo9QJBGlmNrif8vFaKxxcwu8Zm90F0A6o3reflHqT/o6wkfgn /te/JUrvqm4r/XfboV87Ac71W0YuPfLyAgrH7H8SfedWsZzkZI53NEd93OO2mDktlLkGu7R63zE qNdbs/4N5LDIUx7v5/KARXIiBUk/UrlI5OBOnm4qL+fP2bUfPlz+8sePPaEkGTVHzv3vWxhT5L4 VW1KutmBFd4BSmUFO/V97OLn/DzSRu0jffzYtJhUVCFKKv6lkJwruROxnNZTRJWy+FHAXFZIyEn FrtYUk/Uofj9j9ZDIdQ== X-Proofpoint-ORIG-GUID: wyyaagvZ1D0xq6-k2ZYQ6KJQhA8hH9uS X-Authority-Analysis: v=2.4 cv=PI0COPqC c=1 sm=1 tr=0 ts=69ca5d48 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=x5R1qbOTbg2SGMIGZqsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: wyyaagvZ1D0xq6-k2ZYQ6KJQhA8hH9uS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 adultscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300089 On 3/25/2026 3:02 PM, Konrad Dybcio wrote: > On 3/24/26 9:51 PM, Dmitry Baryshkov wrote: >> On Tue, Mar 24, 2026 at 06:43:20PM +0530, Viken Dadhaniya wrote: >>> The Talos (QCS615) platform includes a QSPI controller used for accessing >>> external flash storage. Add the QSPI OPP table, TLMM pinmux entries, and >>> the QSPI controller node to enable support for this hardware. >>> >>> Signed-off-by: Viken Dadhaniya >>> --- >>> arch/arm64/boot/dts/qcom/talos.dtsi | 80 +++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 80 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/talos.dtsi b/arch/arm64/boot/dts/qcom/talos.dtsi >>> index 75716b4a58d6..fd727924b8ca 100644 >>> --- a/arch/arm64/boot/dts/qcom/talos.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/talos.dtsi >>> @@ -530,6 +530,25 @@ cdsp_smp2p_in: slave-kernel { >>> >>> }; >>> >>> + qspi_opp_table: opp-table-qspi { >> >> Why is it not defined inside the QSPI device itself? > > The QSPI device has #address-cells = <1>, so we'd get: > > Warning (spi_bus_reg): /soc@0/spi@88dc000/opp-table-qspi: missing or empty reg property > > Konrad Yes, I am seeing the same warning when the OPP table is placed inline under the QSPI node. Given that opp-table nodes are not addressable bus devices and therefore do not define a reg property, what would be your preferred way to model this while keeping the DT warning‑free? Would placing the OPP table as a sibling of the QSPI node (for example under the same &soc scope) and referencing it via operating-points-v2 be acceptable in this case, even though there is only a single QSPI instance? Thanks for your guidance. Best regards, Viken