From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754144AbcHXKJ6 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 24 Aug 2016 06:09:58 -0400
Received: from mout.kundenserver.de ([217.72.192.73]:50351 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751799AbcHXKJ4 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 24 Aug 2016 06:09:56 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Dave Airlie <airlied@redhat.com>, David Airlie <airlied@linux.ie>,
        Noralf =?ISO-8859-1?Q?Tr=F8nnes?= <noralf@tronnes.org>,
        Chris Wilson <chris@chris-wilson.co.uk>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fb: udl: fix build without CONFIG_FB_DEFERRED_IO
Date: Wed, 24 Aug 2016 12:02:19 +0200
Message-ID: <2006626.l0meP6FYuH@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-31-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <CAKMK7uG1iQJ1JStobyGLpBaba=N7zwBxJxgy=xA=xi-xoE+SDQ@mail.gmail.com>
References: <20160824082738.703060-1-arnd@arndb.de> <CAKMK7uG1iQJ1JStobyGLpBaba=N7zwBxJxgy=xA=xi-xoE+SDQ@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:xkZuSqtxf+QMFlc5jRJ1TeE/V+46QnGmcquvg1bFj12KdhTui7d
 ysOQXcxGbLkEQWeU9U7u4uj56+0PXhbVsYd5WbeVpo8Jko7JlOjXovxbvqXBFaU/1E0Wtbc
 2fCCmVZ24YqgvwggJcvIn5dVt80LxKod1aSjqaDipd9zJb234DXO+n8QO//JtzBUZaxRqh1
 2bbro3YFi4SnjmnXmJT5g==
X-UI-Out-Filterresults: notjunk:1;V01:K0:Ml10jtFitTw=:AxYk3fG5cD4Su3ETQWgAoZ
 J+blMVTdJPSP3AtcmEkAl6ZhS2ruzC1IVKN5nJgKtTjrV/iaTUpnAfGANK6qH+p0bHk23Zn6G
 kSC5C+D00qkzexEFmujzrcESyUFsGEt9zfCKw2gZW6bSwotM1GFC+CcsXri2y2ab7LjkKbIeS
 Z+YEts+NU/FlTnyPOFwRcaS0RA8iQkaJYtrY+VY59SYgvYOgTpJLYEBlvFqYwB2a/TkTHEoAo
 b36Lyu6szxEOPsKiBPEOoJdtbeD/DziHwM0ymDrvfM6lJ709+urDPyq70jB4VqvG2je7V6Xki
 /PE8tigdAUHmF0nHSuapXYRzVnv7y0nf9OWX3hlu5HFwdUMG0I4FVUGVwMtP8AdvI1jaTnHqD
 wOYw5VU5kuSkaCvuzas8rJEtpN7Tgs8bX0nic0hybCNM6k/n5EbWXdeeSp0j/Ovu7kPvnYShb
 1mghhYoN6Kf1zSpOW4mFHGwKZwjN6kG+e+l0oPxrLCFRhmVqIg0N2GKUXw043/mXmI0J+Rcqq
 C0qSOOdPui6Gr8w5T//mkXVRGLjIn29KvOb7zSK/r1OUOgy8uRuX8blyKg0CdE/ABD/AlVYTf
 ZpJ+r7gB6QQrwESkrR9rIXSOoU+3x8tK7TqjPSf35++GTerb/ykHqGK/eD6NVKGwyWRNQ3dzS
 mHMH1oxeuKNhqwMp8ErYtl3jjsq2XYgej+NevFcT6ph6bIUO4qkoLWu1YxpKpnxNT06OlS9Nq
 q2tSbBkytEtBfu3E
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday, August 24, 2016 11:01:17 AM CEST Daniel Vetter wrote:
> On Wed, Aug 24, 2016 at 10:27 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > A cleanup in v4.8 dropped several dependencies, but caused the udl driver
> > to fail building when CONFIG_FB_DEFERRED_IO is not set:
> >
> > drivers/gpu/drm/udl/udl_fb.c: In function 'udl_fb_open':
> > drivers/gpu/drm/udl/udl_fb.c:206:23: error: 'struct fb_info' has no member named 'fbdefio'
> >   if (fb_defio && (info->fbdefio == NULL)) {
> >                        ^~
> >
> > This adds an #ifdef check around the code that fails. We know this
> > is safe because it always checks info->fbdefio for being non-NULL,
> > and that member is not defined here.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: c0f0c177b5a9 ("drm/udl: make fbdev support really optional")
> 
> There's a pile more needed, which is why I just ended up stuffing them
> all into linux-next for 4.9. Is your patch still needed on that? If we
> really want this fixed in 4.8 I guess I can assemble a cherry-pick
> list.

Ok, got it. I think your 0c756134cf76 ("drm: Protect fb_defio in
drivers with CONFIG_KMS_FBDEV_EMULATION") is actually sufficient
for the build break, it's almost the same as my patch anyway.

Alternatively, reverting c0f0c177b5a9 ("drm/udl: make fbdev
support really optional") for v4.8 would work too.

	Arnd