mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephan Mueller <smueller@chronox.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
	aquini@redhat.com, jeremy.wayne.powell@gmail.com,
	clemens@ladisch.de, pwalten@au1.ibm.com, joe@perches.com
Subject: Re: [PATCH v7 1/6] SP800-90A Deterministic Random Bit Generator
Date: Mon, 26 May 2014 07:44:15 +0200	[thread overview]
Message-ID: <2006828.NMLXLGt5ck@myon.chronox.de> (raw)
In-Reply-To: <20140523211007.GA20955@gondor.apana.org.au>

Am Samstag, 24. Mai 2014, 05:10:07 schrieb Herbert Xu:

Hi Herbert,

> Stephan Mueller <smueller@chronox.de> wrote:
> > +       memset(&drbg_algs[i], 0, sizeof(struct crypto_alg));
> > +       if (pr) {
> > +               memcpy(drbg_algs[i].cra_name, "drbg(pr(", 8);
> > +               memcpy(drbg_algs[i].cra_driver_name, "drbg_pr_", 8);
> > +               pos = 8;
> 
> You shouldn't use the brackets here since this not a real template.
> Just use one name for both cra_name and cra_driver_name.

Thanks for the hint: I would use the name specified for cra_driver_name also 
for cra_name
> 
> Cheers,


Ciao
Stephan
-- 
| Cui bono? |

  reply	other threads:[~2014-05-26  5:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-21  4:18 [PATCH v7 0/6] " Stephan Mueller
2014-05-21  4:18 ` [PATCH v7 1/6] " Stephan Mueller
2014-05-21 20:17   ` Stephan Mueller
2014-05-23 21:10   ` Herbert Xu
2014-05-26  5:44     ` Stephan Mueller [this message]
2014-05-21  4:19 ` [PATCH v7 2/6] header file for DRBG Stephan Mueller
2014-05-21  4:20 ` [PATCH v7 3/6] DRBG kernel configuration options Stephan Mueller
2014-05-21  4:21 ` [PATCH v7 4/6] compile the DRBG code Stephan Mueller
2014-05-21  4:21 ` [PATCH v7 5/6] DRBG testmgr test vectors Stephan Mueller
2014-05-21  4:22 ` [PATCH v7 6/6] Add DRBG test code to testmgr Stephan Mueller
2014-05-23 21:14 ` [PATCH v7 0/6] SP800-90A Deterministic Random Bit Generator Herbert Xu
2014-05-26  5:42   ` Stephan Mueller
2014-05-30  9:05     ` Herbert Xu
2014-05-30 10:08       ` Stephan Mueller
2014-05-30 10:52         ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2006828.NMLXLGt5ck@myon.chronox.de \
    --to=smueller@chronox.de \
    --cc=aquini@redhat.com \
    --cc=clemens@ladisch.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=jeremy.wayne.powell@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pwalten@au1.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome