From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932860AbXABLbs (ORCPT ); Tue, 2 Jan 2007 06:31:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932857AbXABLbr (ORCPT ); Tue, 2 Jan 2007 06:31:47 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:45346 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932821AbXABLbq (ORCPT ); Tue, 2 Jan 2007 06:31:46 -0500 Date: Tue, 2 Jan 2007 11:31:44 +0000 From: Christoph Hellwig To: Geert Uytterhoeven Cc: Linus Torvalds , Andrew Morton , linux-scsi@vger.kernel.org, Linux Kernel Development , Sam Creasey Subject: Re: [PATCH] Sun3 SCSI: Make sun3 scsi drivers compile/work again Message-ID: <20070102113143.GB24951@infradead.org> Mail-Followup-To: Christoph Hellwig , Geert Uytterhoeven , Linus Torvalds , Andrew Morton , linux-scsi@vger.kernel.org, Linux Kernel Development , Sam Creasey References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 09, 2006 at 10:37:05AM +0100, Geert Uytterhoeven wrote: > +#include "initio.h" This is definitly wrong. This is a header file for a specific driver. I suspect you want the old-EH definitions for SCSI_RESET_*/SCSI_ABORT_*? You're returning them from the EH routines which are plugged into the new EH method slots, so this is not only wrong by including an other drivers private headers but also functionally deadly.