Re: [PATCH 1/2] EDAC: e752x-bit-mask-fix

[Randy Dunlap <randy.dunlap@oracle.com>]

On Tue, 2 Jan 2007 16:13:36 -0800 (PST) Doug Thompson wrote:

> from: Brian Pomerantz <bapper@mvista.com>
> 
> Description:
>     The fatal vs. non-fatal mask for the sysbus FERR status is
> incorrect
>     according to the E7520 datasheet.  This patch corrects the mask to
> correctly
>     handle fatal and non-fatal errors.
> 
> Signed-off-by: Brian Pomerantz <bapper@mvista.com>
> Signed-off-by: Dave Jiang <djiang@mvista.com>
> Signed-off-by: Doug Thompson <norsk5@xmission.com>
> 
>  e752x_edac.c |   16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> Index: linux-2.6.18/drivers/edac/e752x_edac.c
> ===================================================================
> --- linux-2.6.18.orig/drivers/edac/e752x_edac.c
> +++ linux-2.6.18/drivers/edac/e752x_edac.c
> @@ -561,17 +561,17 @@ static void e752x_check_sysbus(struct e7
>  	error32 = (stat32 >> 16) & 0x3ff;
>  	stat32 = stat32 & 0x3ff;
>  
> -	if(stat32 & 0x083)
> -		sysbus_error(1, stat32 & 0x083, error_found, handle_error);
> +	if(stat32 & 0x087)
> +		sysbus_error(1, stat32 & 0x087, error_found, handle_error);
>  
> -	if(stat32 & 0x37c)
> -		sysbus_error(0, stat32 & 0x37c, error_found, handle_error);
> +	if(stat32 & 0x378)
> +		sysbus_error(0, stat32 & 0x378, error_found, handle_error);
>  
> -	if(error32 & 0x083)
> -		sysbus_error(1, error32 & 0x083, error_found, handle_error);
> +	if(error32 & 0x087)
> +		sysbus_error(1, error32 & 0x087, error_found, handle_error);
>  
> -	if(error32 & 0x37c)
> -		sysbus_error(0, error32 & 0x37c, error_found, handle_error);
> +	if(error32 & 0x378)
> +		sysbus_error(0, error32 & 0x378, error_found, handle_error);
>  }

	if (

Are these bit masks documented somewhere?

You could make that almost readable by using some #defines for them.

---
~Randy