From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] fix memory corruption from misinterpreted bad_inode_ops return values
Date: Thu, 4 Jan 2007 10:14:23 +1100 [thread overview]
Message-ID: <20070104101423.06bdd664.sfr@canb.auug.org.au> (raw)
In-Reply-To: <459BF927.2020108@sandeen.net>
[-- Attachment #1: Type: text/plain, Size: 895 bytes --]
Hi Eric,
On Wed, 03 Jan 2007 12:42:47 -0600 Eric Sandeen <sandeen@sandeen.net> wrote:
>
> So here's the first stab at fixing it. I'm sure there are style points
> to be hashed out. Putting all the functions as static inlines in a header
> was just to avoid hundreds of lines of simple function declarations before
> we get to the meat of bad_inode.c, but it's probably technically wrong to
> put it in a header. Also if putting a copyright on that trivial header file
> is going overboard, just let me know. Or if anyone has a less verbose
> but still correct way to address this problem, I'm all ears.
Since the only uses of these functions is to take their addresses, the
inline gains you nothing and since the only uses are in the one file, you
should just define them in that file.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-01-03 23:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-03 18:42 Eric Sandeen
2007-01-03 23:14 ` Stephen Rothwell [this message]
2007-01-03 23:21 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070104101423.06bdd664.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®