mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: David Brownell <david-b@pacbell.net>
Cc: rtc-linux@googlegroups.com,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>,
	Russell King <rmk@arm.linux.org.uk>,
	Woody Suwalski <woodys@xandros.com>
Subject: Re: [patch 2.6.20-rc3 1/3] rtc-cmos driver
Date: Fri, 5 Jan 2007 21:45:09 +0100	[thread overview]
Message-ID: <20070105214509.12190340@inspiron> (raw)
In-Reply-To: <200701051001.58472.david-b@pacbell.net>

On Fri, 5 Jan 2007 10:01:57 -0800
David Brownell <david-b@pacbell.net> wrote:

> This is an "RTC framework" driver for the "CMOS" RTCs which are standard
> on PCs and some other platforms.  That's MC146818 compatible silicon.
> Advantages of this vs. drivers/char/rtc.c (use one _or_ the other, only
> one will be able to claim the RTC irq) include:

 Hi David,

  good code and well commented, thank you.
 
 I only have some comments:

 - I would put anything that is x86 related (pnp,acpi)
 in a separate file so that people working on
 non x86 systems can have a better grasp of the driver.
 
 - the name should be rtc-mc146818 to be coherent with
 the other drivers, but this can cause confusion.

 - please put yourself in MODULE_AUTHOR

 other than that, I'm fine with the code.

 I'd appreciate if someone (Woody?) can test
 this code on ARM.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it


  reply	other threads:[~2007-01-05 20:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-05 18:01 David Brownell
2007-01-05 20:45 ` Alessandro Zummo [this message]
2007-01-06  3:10   ` David Brownell
2007-01-06  3:33     ` David Brownell
2007-01-06 17:17       ` Woody Suwalski
2007-01-06 21:17         ` David Brownell
2007-01-07  9:02           ` Russell King
2007-01-09 16:37             ` Woody Suwalski
2007-01-10  0:01               ` David Brownell
2007-01-10  5:27                 ` David Brownell
2007-05-28 18:35 ` Matthew Garrett
2007-05-28 21:07   ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070105214509.12190340@inspiron \
    --to=alessandro.zummo@towertech.it \
    --cc=akpm@osdl.org \
    --cc=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=rtc-linux@googlegroups.com \
    --cc=woodys@xandros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®