From: Randy Dunlap <randy.dunlap@oracle.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: lkml <linux-kernel@vger.kernel.org>, akpm <akpm@osdl.org>,
kernel@bardioc.dyndns.org
Subject: [PATCH] sysrq: showBlockedTasks is sysrq-W
Date: Sat, 6 Jan 2007 10:25:31 -0800 [thread overview]
Message-ID: <20070106102531.29ce662c.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20070105193605.GA14592@aepfle.de>
On Fri, 5 Jan 2007 20:36:05 +0100 Olaf Hering wrote:
> On Fri, Jan 05, Randy Dunlap wrote:
>
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > SysRq showBlockedTasks is not done via B or T, it's done via X,
> > so put that in the Help message.
>
> Weird, who failed to run this command before adding new stuff?!
> find * -type f -print0 | xargs -0 env -i grep -nw register_sysrq_key
>
> sysrq x is for xmon, see arch/powerpc/xmon/xmon.c
> Better switch the new stuff to 'z' or 'w'
---
From: Randy Dunlap <randy.dunlap@oracle.com>
SysRq showBlockedTasks is not done via B or T, it's done via W,
so put that in the Help message.
It was previously done via X, but X is already used for Xmon
on powerpc platforms and this collision needs to be avoided.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/char/sysrq.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- linux-2620-rc3g4.orig/drivers/char/sysrq.c
+++ linux-2620-rc3g4/drivers/char/sysrq.c
@@ -215,7 +215,7 @@ static void sysrq_handle_showstate_block
}
static struct sysrq_key_op sysrq_showstate_blocked_op = {
.handler = sysrq_handle_showstate_blocked,
- .help_msg = "showBlockedTasks",
+ .help_msg = "showBlockedTasks(W)",
.action_msg = "Show Blocked State",
.enable_mask = SYSRQ_ENABLE_DUMP,
};
@@ -342,8 +342,8 @@ static struct sysrq_key_op *sysrq_key_ta
&sysrq_mountro_op, /* u */
/* May be assigned at init time by SMP VOYAGER */
NULL, /* v */
- NULL, /* w */
- &sysrq_showstate_blocked_op, /* x */
+ &sysrq_showstate_blocked_op, /* w */
+ NULL, /* x */
NULL, /* y */
NULL /* z */
};
next prev parent reply other threads:[~2007-01-06 18:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-05 19:06 [PATCH] sysrq: showBlockedTasks is sysrq-X Randy Dunlap
2007-01-05 19:36 ` Olaf Hering
2007-01-05 19:41 ` Randy Dunlap
2007-01-05 19:51 ` Olaf Hering
2007-01-06 18:25 ` Randy Dunlap [this message]
2007-01-06 19:19 ` [PATCH] sysrq: showBlockedTasks is sysrq-W Torsten Kaiser
2007-01-06 20:04 ` Randy Dunlap
2007-01-06 22:04 ` [PATCH 1/2 v3] " Randy Dunlap
2007-01-07 0:09 ` Dave Jones
2007-01-07 2:36 ` [PATCH 1/2 v4] " Randy Dunlap
2007-01-07 2:41 ` Dave Jones
2007-01-06 22:04 ` [PATCH 2/2] sysrq: alphabetize command keys doc Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070106102531.29ce662c.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@osdl.org \
--cc=kernel@bardioc.dyndns.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome