From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Kyle McMartin <kyle@parisc-linux.org>
Cc: Christoph Hellwig <hch@infradead.org>,
akpm@osdl.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, parisc-linux@lists.parisc-linux.org
Subject: Re: [PATCH] Common compat_sys_sysinfo (v2)
Date: Mon, 8 Jan 2007 10:43:47 +1100 [thread overview]
Message-ID: <20070108104347.83a004aa.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20070107154045.GD3207@athena.road.mcmartin.ca>
[-- Attachment #1: Type: text/plain, Size: 834 bytes --]
Hi Kyle,
Looks good. Just one nit and one comment.
On Sun, 7 Jan 2007 10:40:45 -0500 Kyle McMartin <kyle@parisc-linux.org> wrote:
>
> diff --git a/kernel/compat.c b/kernel/compat.c
> index 6952dd0..cebb4c2 100644
> --- a/kernel/compat.c
> +++ b/kernel/compat.c
.
.
.
> + __put_user (s.uptime, &info->uptime) ||
^
We don't put spaces in here ...
> +asmlinkage long sys_sysinfo(struct sysinfo __user *info)
> +{
> + struct sysinfo val;
> +
> + do_sysinfo(&val);
>
> - out:
> if (copy_to_user(info, &val, sizeof(struct sysinfo)))
> return -EFAULT;
People have complined before that this adds a whole stack frame to the
"normal" syscall path. Personally I don't care, but it has been
mentioned.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-01-07 23:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-07 14:48 [PATCH] Common compat_sys_sysinfo Kyle McMartin
2007-01-07 15:13 ` Christoph Hellwig
2007-01-07 15:18 ` Matthew Wilcox
2007-01-07 15:22 ` Kyle McMartin
2007-01-07 15:40 ` [PATCH] Common compat_sys_sysinfo (v2) Kyle McMartin
2007-01-07 23:43 ` Stephen Rothwell [this message]
2007-01-08 5:54 ` Arnd Bergmann
2007-01-08 7:29 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070108104347.83a004aa.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=kyle@parisc-linux.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=parisc-linux@lists.parisc-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®