From: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ppc: cpm2_pic of_node_get cleanup
Date: Tue, 9 Jan 2007 11:24:03 +0100 [thread overview]
Message-ID: <200701091124.04949.m.kozlowski@tuxland.pl> (raw)
In-Reply-To: <17827.8109.461427.191194@cargo.ozlabs.ibm.com>
Hello,
> Mariusz Kozlowski writes:
>
> > This patch removes redundant argument check for of_node_get().
> >
> > Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
> >
> > arch/powerpc/sysdev/cpm2_pic.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff -upr linux-2.6.20-rc2-mm1-a/arch/powerpc/sysdev/cpm2_pic.c linux-2.6.20-rc2-mm1-b/arch/powerpc/sysdev/cpm2_pic.c
> > --- linux-2.6.20-rc2-mm1-a/arch/powerpc/sysdev/cpm2_pic.c 2006-12-24 05:00:32.000000000 +0100
> > +++ linux-2.6.20-rc2-mm1-b/arch/powerpc/sysdev/cpm2_pic.c 2007-01-02 02:04:25.000000000 +0100
> > @@ -245,9 +245,7 @@ void cpm2_pic_init(struct device_node *n
> > cpm2_intctl->ic_scprrl = 0x05309770;
> >
> > /* create a legacy host */
> > - if (node)
> > - cpm2_pic_node = of_node_get(node);
> > -
> > + cpm2_pic_node = of_node_get(node);
>
> This is actually a semantic change, in that cpm2_pic_node always gets
> assigned now, whereas previously it didn't if node == NULL. Are you
> sure that is OK? If so, you need to add something to the patch
> description explaining why it is OK.
It's ok to remove 'node' check because in real life cpm2_pic_init() never
gets called with node == NULL.
Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
arch/powerpc/sysdev/cpm2_pic.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff -upr linux-2.6.20-rc2-mm1-a/arch/powerpc/sysdev/cpm2_pic.c linux-2.6.20-rc2-mm1-b/arch/powerpc/sysdev/cpm2_pic.c
--- linux-2.6.20-rc2-mm1-a/arch/powerpc/sysdev/cpm2_pic.c 2006-12-24 05:00:32.000000000 +0100
+++ linux-2.6.20-rc2-mm1-b/arch/powerpc/sysdev/cpm2_pic.c 2007-01-02 02:04:25.000000000 +0100
@@ -245,9 +245,7 @@ void cpm2_pic_init(struct device_node *n
cpm2_intctl->ic_scprrl = 0x05309770;
/* create a legacy host */
- if (node)
- cpm2_pic_node = of_node_get(node);
-
+ cpm2_pic_node = of_node_get(node);
cpm2_pic_host = irq_alloc_host(IRQ_HOST_MAP_LINEAR, 64, &cpm2_pic_host_ops, 64);
if (cpm2_pic_host == NULL) {
printk(KERN_ERR "CPM2 PIC: failed to allocate irq host!\n");
--
Regards,
Mariusz Kozlowski
prev parent reply other threads:[~2007-01-09 10:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-02 11:36 Mariusz Kozlowski
2007-01-09 4:53 ` Paul Mackerras
2007-01-09 10:24 ` Mariusz Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701091124.04949.m.kozlowski@tuxland.pl \
--to=m.kozlowski@tuxland.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®