From: Andrew Morton <akpm@osdl.org>
To: Andi Kleen <ak@suse.de>
Cc: Adrian Bunk <bunk@stusta.de>,
discuss@x86-64.org, linux-kernel@vger.kernel.org,
"Steven M. Christey" <coley@mitre.org>
Subject: Re: [2.6 patch] x86_64: re-add a newline to RESTORE_CONTEXT
Date: Tue, 9 Jan 2007 14:04:24 -0800 [thread overview]
Message-ID: <20070109140424.5f96de69.akpm@osdl.org> (raw)
In-Reply-To: <200701091201.21146.ak@suse.de>
On Tue, 9 Jan 2007 12:01:21 +0100
Andi Kleen <ak@suse.de> wrote:
> On Tuesday 09 January 2007 03:55, Adrian Bunk wrote:
> > RESTORE_CONTEXT lost a newline in
> > commit 658fdbef66e5e9be79b457edc2cbbb3add840aa9:
> > http://www.mail-archive.com/kgdb-bugreport@lists.sourceforge.net/msg00559.html
>
> I don't think we should add such changes for external patchkits.
>
> In general kgdb shouldn't add any patches at all. If the existing
> hooks are not enough they should submit their changes needed so
> that it can just work.
>
But the patch is a bugfix. Without it, you cannot do
RESTORE_CONTEXT \
.globl ... \
Was the addition of this restriction to RESTORE_CONTEXT deliberate, or
mistaken?
next prev parent reply other threads:[~2007-01-09 22:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-09 2:55 Adrian Bunk
2007-01-09 11:01 ` Andi Kleen
2007-01-09 22:04 ` Andrew Morton [this message]
2007-01-09 22:43 ` Andi Kleen
2007-01-09 22:52 ` Andrew Morton
2007-01-09 23:43 ` Andi Kleen
2007-01-10 8:37 ` [discuss] " Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070109140424.5f96de69.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@suse.de \
--cc=bunk@stusta.de \
--cc=coley@mitre.org \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome