mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oliver Neukum <oliver@neukum.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: linux-usb-devel@lists.sourceforge.net,
	Andrew Morton <akpm@osdl.org>, Greg KH <greg@kroah.com>,
	Pavel Machek <pavel@ucw.cz>,
	kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [linux-usb-devel] 2.6.20-rc4: null pointer deref in khubd
Date: Wed, 10 Jan 2007 20:54:56 +0100	[thread overview]
Message-ID: <200701102054.57303.oliver@neukum.org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0701101230390.3289-100000@iolanthe.rowland.org>

Am Mittwoch, 10. Januar 2007 18:31 schrieb Alan Stern:
> > Regarding the bug this device uncovers, it seems to me that this in drivers/base/core.c
> >       if (parent)
> >               klist_add_tail(&dev->knode_parent, &parent->klist_children);
> > should make knode_parent a valid node under all circumstances.
> > Hm.
> 
> I haven't seen the original bug report.  Where does the NULL pointer deref 
> occur?

Apparently here: drivers/base/core.c:

void device_del(struct device * dev)
{
	struct device * parent = dev->parent;
	struct class_interface *class_intf;

	if (parent)
		klist_del(&dev->knode_parent);

The obvious change with this device is that usb_set_configuration() is never
called, but that should not matter.

	Regards
		Oliver

  reply	other threads:[~2007-01-10 19:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-10 10:49 Pavel Machek
2007-01-10 15:49 ` Oliver Neukum
2007-01-10 16:14   ` [linux-usb-devel] " Alan Stern
2007-01-10 17:01     ` Oliver Neukum
2007-01-10 17:31       ` Alan Stern
2007-01-10 19:54         ` Oliver Neukum [this message]
2007-01-10 22:35           ` Alan Stern
2007-01-10 22:56             ` Pavel Machek
2007-01-11  7:48             ` Oliver Neukum
2007-01-11 10:34               ` Pavel Machek
2007-01-11 13:08                 ` Oliver Neukum
2007-01-10 20:38   ` Pavel Machek
2007-01-11 13:21     ` [linux-usb-devel] " Oliver Neukum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200701102054.57303.oliver@neukum.org \
    --to=oliver@neukum.org \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=pavel@ucw.cz \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome