From: Andrew Morton <akpm@osdl.org>
To: Pierre Peiffer <pierre.peiffer@bull.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Dinakar Guniguntala" <dino@in.ibm.com>,
"Jean-Pierre Dion" <jean-pierre.dion@bull.net>,
"Ingo Molnar" <mingo@elte.hu>,
"Ulrich Drepper" <drepper@redhat.com>,
"Jakub Jelinek" <jakub@redhat.com>,
"Darren Hart" <dvhltc@us.ibm.com>,
"Sébastien Dugué" <sebastien.dugue@bull.net>
Subject: Re: [PATCH 2.6.20-rc4 4/4][RFC] sys_futex64 : allows 64bit futexes
Date: Thu, 11 Jan 2007 13:49:04 -0800 [thread overview]
Message-ID: <20070111134904.44d89572.akpm@osdl.org> (raw)
In-Reply-To: <45A3C1F6.4020503@bull.net>
On Tue, 09 Jan 2007 17:25:26 +0100
Pierre Peiffer <pierre.peiffer@bull.net> wrote:
> static inline int
> +futex_atomic_op_inuser64 (int encoded_op, u64 __user *uaddr)
Your email client performs space-stuffing. Please see if you can turn that
off. (It's fixable at my end with s/^ /^/g but it's a nuisance).
> +{
> + int op = (encoded_op >> 28) & 7;
> + int cmp = (encoded_op >> 24) & 15;
> + u64 oparg = (encoded_op << 8) >> 20;
> + u64 cmparg = (encoded_op << 20) >> 20;
> + u64 oldval = 0, ret, tem;
> +
> + if (encoded_op & (FUTEX_OP_OPARG_SHIFT << 28))
> + oparg = 1 << oparg;
> +
> + if (! access_ok (VERIFY_WRITE, uaddr, sizeof(u64)))
> + return -EFAULT;
> +
> + inc_preempt_count();
What is that open-coded, uncommented inc_preempt_count() doing in there?
next prev parent reply other threads:[~2007-01-11 21:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <45A3B330.9000104@bull.net>
2007-01-09 16:16 ` [PATCH 2.6.20-rc4 1/4] futex priority based wakeup Pierre Peiffer
2007-01-09 16:29 ` Ulrich Drepper
2007-01-10 11:47 ` Pierre Peiffer
2007-01-10 12:03 ` Pierre Peiffer
2007-01-10 12:54 ` Jakub Jelinek
2007-01-10 15:05 ` Pierre Peiffer
2007-01-10 18:15 ` Ulrich Drepper
2007-01-11 7:20 ` Ulrich Drepper
2007-01-09 17:59 ` Daniel Walker
2007-01-10 16:11 ` Daniel Walker
2007-01-10 16:29 ` Pierre Peiffer
2007-01-10 16:33 ` Daniel Walker
2007-01-09 16:16 ` [PATCH 2.6.20-rc4 2/4] Make futex_wait() use an hrtimer for timeout Pierre Peiffer
2007-01-09 16:20 ` [PATCH 2.6.20-rc4 3/4] futex_requeue_pi optimization Pierre Peiffer
2007-01-09 16:33 ` Ulrich Drepper
2007-01-10 8:17 ` Pierre Peiffer
2007-01-10 8:24 ` Ulrich Drepper
2007-01-09 16:25 ` [PATCH 2.6.20-rc4 4/4][RFC] sys_futex64 : allows 64bit futexes Pierre Peiffer
2007-01-11 21:49 ` Andrew Morton [this message]
2007-01-11 22:14 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070111134904.44d89572.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=dino@in.ibm.com \
--cc=drepper@redhat.com \
--cc=dvhltc@us.ibm.com \
--cc=jakub@redhat.com \
--cc=jean-pierre.dion@bull.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pierre.peiffer@bull.net \
--cc=sebastien.dugue@bull.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®