mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: "Serge E. Hallyn" <serue@us.ibm.com>,
	Christoph Hellwig <hch@infradead.org>,
	Arjan van de Ven <arjan@infradead.org>,
	Mimi Zohar <zohar@us.ibm.com>,
	akpm@osdl.org, kjhall@linux.vnet.ibm.com,
	linux-kernel@vger.kernel.org, safford@saff.watson.ibm.com
Subject: Re: mprotect abuse in slim
Date: Thu, 11 Jan 2007 09:49:57 -0600	[thread overview]
Message-ID: <20070111154957.GG4791@sergelap.austin.ibm.com> (raw)
In-Reply-To: <84144f020701102339n1935b0a7v5ca3419fe3b66be5@mail.gmail.com>

Quoting Pekka Enberg (penberg@cs.helsinki.fi):
> On 1/10/07, Serge E. Hallyn <serue@us.ibm.com> wrote:
> >But since it looks like you just munmap the region now, shouldn't a
> >subsequent munmap by the app just return -EINVAL?  that seems appropriate
> >to me.
> 
> Applications don't know about revoke and neither should they.
> Therefore close(2) and munmap(2) must work the same way they would for
> non-revoked inodes so that applications can release resources
> properly.
> 
>                                         Pekka

Right, but is returning -EINVAL to userspace on munmap a problem?
It may not have been expected before, but it shouldn't break
anything...

Thanks for the tw other patches - I'll give them a shot and check
out current munmap behavior just as soon as I get a chance.

thanks,
-serge


  reply	other threads:[~2007-01-11 15:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-08 13:41 Christoph Hellwig
2007-01-08 22:38 ` Mimi Zohar
2007-01-09  3:07   ` Arjan van de Ven
2007-01-09  9:46     ` Christoph Hellwig
2007-01-09 20:54       ` Chris Wright
2007-01-09 23:14       ` Serge E. Hallyn
2007-01-10  7:21         ` Pekka J Enberg
2007-01-10 15:58           ` Serge E. Hallyn
2007-01-11  7:39             ` Pekka Enberg
2007-01-11 15:49               ` Serge E. Hallyn [this message]
2007-01-12  7:43                 ` Pekka Enberg
2007-01-12 15:17                   ` Serge E. Hallyn
2007-01-12  9:45         ` Pekka Enberg
2007-01-12 19:28           ` Serge E. Hallyn
2007-01-12 19:53             ` Pekka J Enberg
2007-01-09 21:30     ` Mimi Zohar
2007-01-09 19:27   ` Valdis.Kletnieks
2007-01-09 21:45     ` Mimi Zohar
2007-01-11 14:35   ` Pavel Machek
2007-01-12 20:08     ` Mimi Zohar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070111154957.GG4791@sergelap.austin.ibm.com \
    --to=serue@us.ibm.com \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=hch@infradead.org \
    --cc=kjhall@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=safford@saff.watson.ibm.com \
    --cc=zohar@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®