From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: V4L-DVB Maintainers <v4l-dvb-maintainer@linuxtv.org>,
Grant Likely <grant.likely@secretlab.ca>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: [PATCH 4/9] V4L/DVB (5024): Fix quickcam communicator driver for big endian architectures
Date: Mon, 15 Jan 2007 16:37:06 -0200 [thread overview]
Message-ID: <20070115183705.PS9920820004@infradead.org> (raw)
In-Reply-To: <20070115183647.PS0588920000@infradead.org>
From: Grant Likely <grant.likely@secretlab.ca>
Host endianess does not affect the order that pixel rgb data comes
in from the quickcam (the values are bytes, not words or longs). The
driver is erroniously swapping the order of rgb values for big endian
machines. This patch is needed get the Quickcam communicator working
on big endian machines (tested on powerpc)
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
---
drivers/media/video/usbvideo/quickcam_messenger.h | 14 --------------
1 files changed, 0 insertions(+), 14 deletions(-)
diff --git a/drivers/media/video/usbvideo/quickcam_messenger.h b/drivers/media/video/usbvideo/quickcam_messenger.h
index baab9c0..17ace39 100644
--- a/drivers/media/video/usbvideo/quickcam_messenger.h
+++ b/drivers/media/video/usbvideo/quickcam_messenger.h
@@ -35,27 +35,13 @@ struct rgb {
};
struct bayL0 {
-#ifdef __BIG_ENDIAN
- u8 r;
- u8 g;
-#elif __LITTLE_ENDIAN
u8 g;
u8 r;
-#else
-#error not byte order defined
-#endif
};
struct bayL1 {
-#ifdef __BIG_ENDIAN
- u8 g;
- u8 b;
-#elif __LITTLE_ENDIAN
u8 b;
u8 g;
-#else
-#error not byte order defined
-#endif
};
struct cam_size {
next prev parent reply other threads:[~2007-01-15 19:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-15 18:36 [PATCH 0/9] V4L/DVB updates Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 2/9] V4L/DVB (5020): Fix: disable interrupts while at KM_BOUNCE_READ Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 3/9] V4L/DVB (5021): Cx88xx: Fix lockup on suspend Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 1/9] V4L/DVB (5019): Fix the frame->grabstate update in read() entry point Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 7/9] V4L/DVB (5069): Fix bttv and friends on 64bit machines with lots of memory Mauro Carvalho Chehab
2007-01-15 18:37 ` Mauro Carvalho Chehab [this message]
2007-01-15 18:37 ` [PATCH 6/9] V4L/DVB (5033): MSI TV@nywhere Plus fixes Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 5/9] V4L/DVB (5029): Ks0127 status flags Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 9/9] V4L/DVB (5023): Fix compilation on ppc32 architecture Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 8/9] V4L/DVB (5071): Tveeprom: autodetect LG TAPC G701D as tuner type 37 Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070115183705.PS9920820004@infradead.org \
--to=mchehab@infradead.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®