From: Francois Romieu <romieu@fr.zoreil.com>
To: linux-kernel@vger.kernel.org
Cc: Bernhard Walle <bwalle@suse.de>
Subject: Re: [PATCH] Fix compile warnings in r8169
Date: Wed, 17 Jan 2007 19:33:21 +0100 [thread overview]
Message-ID: <20070117183321.GA32388@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20070117141932.GA20534@strauss.suse.de>
Bernhard Walle <bwalle@suse.de> :
> --- linux-2.6.20-rc4.orig/drivers/net/r8169.c 2007-01-07 06:45:51.000000000 +0100
> +++ linux-2.6.20-rc4/drivers/net/r8169.c 2007-01-17 11:39:13.792309228 +0100
[...]
> @@ -2227,7 +2227,7 @@ static int rtl8169_xmit_frags(struct rtl
> {
> struct skb_shared_info *info = skb_shinfo(skb);
> unsigned int cur_frag, entry;
> - struct TxDesc *txd;
> + struct TxDesc *txd = NULL;
>
> entry = tp->cur_tx;
> for (cur_frag = 0; cur_frag < info->nr_frags; cur_frag++) {
The driver is right. This change does not alleviate the maintenance
of the driver nor does it add incentive to fix the compiler.
--
Ueimor
prev parent reply other threads:[~2007-01-17 18:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-17 14:19 Bernhard Walle
2007-01-17 18:33 ` Francois Romieu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070117183321.GA32388@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=bwalle@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®