mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@xenotime.net>
To: Noah Watkins <nwatkins@ittc.ku.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] include linux/fs.h in linux/cdev.h for struct inode
Date: Fri, 19 Jan 2007 11:12:09 -0800	[thread overview]
Message-ID: <20070119111209.ab02d109.rdunlap@xenotime.net> (raw)
In-Reply-To: <11692328473797-git-send-email-nwatkins@ittc.ku.edu>

On Fri, 19 Jan 2007 12:54:07 -0600 Noah Watkins wrote:

> ---
>  include/linux/cdev.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/cdev.h b/include/linux/cdev.h
> index f309b00..b53e2a0 100644
> --- a/include/linux/cdev.h
> +++ b/include/linux/cdev.h
> @@ -5,6 +5,7 @@
>  #include <linux/kobject.h>
>  #include <linux/kdev_t.h>
>  #include <linux/list.h>
> +#include <linux/fs.h>
>  
>  struct cdev {
>  	struct kobject kobj;
> -- 

You can just do this forward declaration instead:

struct inode;

since no struct members are used/needed.

This cuts down on #include spider webs & nests.

---
~Randy

  reply	other threads:[~2007-01-19 19:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-19 18:54 Noah Watkins
2007-01-19 19:12 ` Randy Dunlap [this message]
2007-01-19 20:04 ` Alexey Dobriyan
2007-01-19 22:26 ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070119111209.ab02d109.rdunlap@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nwatkins@ittc.ku.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®