mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
To: Hugh Dickins <hugh@veritas.com>
Cc: Alexey Dobriyan <adobriyan@openvz.org>,
	Andrew Morton <akpm@osdl.org>,
	Richard Purdie <richard@openedhand.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Don't map random pages if swapoff errors
Date: Fri, 19 Jan 2007 22:16:15 +0300	[thread overview]
Message-ID: <20070119191615.GA16601@ms2.inr.ac.ru> (raw)
In-Reply-To: <Pine.LNX.4.64.0701191754020.10013@blonde.wat.veritas.com>

Hello!

> Getting an error there is all the more reason to proceed
> with the swapoff, not to give up and break out of it.

Yes, from this viewpoint more reasonable approach would be to untie
corresponding ptes from swap entry and mark them as invalid to trigger
fault on access.

Not even tried simply because it is definitely not that thing, which
we needed. We used this for process migration and for that purpose
we really need to know when swapoff() fails ASAP to abort migration,
to kill processes which got invalid pages and to resume original copy.
Obviously, delayed fault is absolutely inappropriate for this particular
purpose.

Alexey

      reply	other threads:[~2007-01-19 20:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-19 16:30 Alexey Dobriyan
2007-01-19 18:08 ` Hugh Dickins
2007-01-19 19:16   ` Alexey Kuznetsov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070119191615.GA16601@ms2.inr.ac.ru \
    --to=kuznet@ms2.inr.ac.ru \
    --cc=adobriyan@openvz.org \
    --cc=akpm@osdl.org \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard@openedhand.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome