From: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
To: david-b@pacbell.net
Cc: linux-kernel@vger.kernel.org, mikael.starvik@axis.com,
spi-devel-general@lists.sourceforge.net
Subject: [PATCH 2/2] take 2: (was-kind-of: 3/5 SPI tx_default) 2.6.20-rc6
Date: Fri, 26 Jan 2007 11:48:38 +0100 [thread overview]
Message-ID: <200701261048.l0QAmckm032461@ignucius.se.axis.com> (raw)
In-Reply-To: <200701250502.56467.david-b@pacbell.net> (message from David Brownell on Thu, 25 Jan 2007 05:02:56 -0800)
Just some trivial patches to make sure the existing drivers in
the official tree don't *silently* fail with the introduction of
default_tx_word. Never tested in any way. Not sure if this is
all, for example I didn't look in arch/*.
Signed-off-by: Hans-Peter Nilsson <hp@axis.com>
diff -upr a/drivers/spi/pxa2xx_spi.c b/drivers/spi/pxa2xx_spi.c
--- a/drivers/spi/pxa2xx_spi.c 2007-01-26 10:38:49.000000000 +0100
+++ b/drivers/spi/pxa2xx_spi.c 2007-01-26 11:17:49.000000000 +0100
@@ -1077,6 +1077,9 @@ static int setup(struct spi_device *spi)
if (!spi->bits_per_word)
spi->bits_per_word = 8;
+ if (spi->default_tx_word != 0)
+ return -EINVAL;
+
if (drv_data->ssp_type != PXA25x_SSP
&& (spi->bits_per_word < 4 || spi->bits_per_word > 32)) {
dev_err(&spi->dev, "failed setup: ssp_type=%d, bits/wrd=%d "
diff -upr a/drivers/spi/spi_mpc83xx.c b/drivers/spi/spi_mpc83xx.c
--- a/drivers/spi/spi_mpc83xx.c 2007-01-26 10:38:49.000000000 +0100
+++ b/drivers/spi/spi_mpc83xx.c 2007-01-26 11:19:01.553401939 +0100
@@ -238,6 +238,9 @@ static int mpc83xx_spi_setup(struct spi_
struct mpc83xx_spi *mpc83xx_spi;
int retval;
+ if (spi->default_tx_word != 0)
+ return -EINVAL;
+
if (!spi->max_speed_hz)
return -EINVAL;
diff -upr a/drivers/spi/spi_s3c24xx.c b/drivers/spi/spi_s3c24xx.c
--- a/drivers/spi/spi_s3c24xx.c 2007-01-26 10:38:49.000000000 +0100
+++ b/drivers/spi/spi_s3c24xx.c 2007-01-26 11:19:19.014017640 +0100
@@ -153,6 +153,9 @@ static int s3c24xx_spi_setup(struct spi_
{
int ret;
+ if (spi->default_tx_word != 0)
+ return -EINVAL;
+
if (!spi->bits_per_word)
spi->bits_per_word = 8;
brgds, H-P
prev parent reply other threads:[~2007-01-26 10:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 4:52 [PATCH] 3/5: Updates to SPI and mmc_spi: tx_default, kernel 2.6.19 Hans-Peter Nilsson
2007-01-25 13:02 ` David Brownell
2007-01-26 10:46 ` [PATCH 1/2] take 2: (was-kind-of: 3/5 SPI tx_default) 2.6.20-rc6 Hans-Peter Nilsson
2007-01-26 23:21 ` David Brownell
2007-01-27 4:21 ` David Brownell
2007-01-27 20:19 ` Hans-Peter Nilsson
2007-01-27 20:26 ` Hans-Peter Nilsson
2007-01-27 20:59 ` [PATCH] take 3: mmc_spi with SPI_TX_1 2.6.20-rc6 Hans-Peter Nilsson
2007-01-28 17:46 ` [PATCH] take 4: " Hans-Peter Nilsson
2007-01-27 10:11 ` [PATCH 1/2] take 2: (was-kind-of: 3/5 SPI tx_default) 2.6.20-rc6 Hans-Peter Nilsson
2007-01-27 19:25 ` David Brownell
2007-01-26 10:48 ` Hans-Peter Nilsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701261048.l0QAmckm032461@ignucius.se.axis.com \
--to=hans-peter.nilsson@axis.com \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mikael.starvik@axis.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome