From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752162AbXA0BBy (ORCPT ); Fri, 26 Jan 2007 20:01:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752161AbXA0BBy (ORCPT ); Fri, 26 Jan 2007 20:01:54 -0500 Received: from rhun.apana.org.au ([64.62.148.172]:4382 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751828AbXA0BBx (ORCPT ); Fri, 26 Jan 2007 20:01:53 -0500 Date: Sat, 27 Jan 2007 12:01:46 +1100 From: Herbert Xu To: David Miller Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, deweerdt@free.fr, netdev@vger.kernel.org, frederik.deweerdt@gmail.com, shemminger@osdl.org Subject: Re: + oops-in-drivers-net-shaperc.patch added to -mm tree Message-ID: <20070127010146.GA18851@gondor.apana.org.au> References: <20070125.193128.39155864.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 27, 2007 at 11:45:05AM +1100, Herbert Xu wrote: > David Miller wrote: > > > > Shaper is actually OK. None of these hardware header callbacks > > should be invoked if the device is down. Yet, this is what is > > accidently being allowed in the AF_PACKET socket layer. > > Hmm, what if the device goes down after the check? In fact, the shaper device doesn't even seem to take a ref count of the device it has attached to. So that device can go away at any time. What's more, there are drivers that can change hard_header at run-time (s390). Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt