From: Mike Frysinger <vapier@gentoo.org>
To: netfilter@lists.netfilter.org, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [patch] rename members in dummy _xt_align struct
Date: Mon, 29 Jan 2007 17:25:47 -0500 [thread overview]
Message-ID: <200701291725.47920.vapier@gentoo.org> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 525 bytes --]
i'd like to rename the members in the _xt_align struct in
netfilter/x_tables.h ... by not using 'u8', 'u16', etc..., it's possible to
filter headers meant for userspace through the preprocessor and pull out
people who accidentally utilize these internal types ... however, by using
struct members who have the same name as 'u8', 'u16', etc..., this throws up
a false positive
of all the exported headers, this is the only one to do this sort of thing, so
i hope you guys wont mind making the change :)
-mike
[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]
[-- Attachment #2: linux-netfilter-dont-use-type-names.patch --]
[-- Type: text/x-diff, Size: 567 bytes --]
Use diff variable names than the standard type so we can run automated script
checks on the code to easily pull out export violations.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
--- a/include/linux/netfilter/x_tables.h
+++ b/include/linux/netfilter/x_tables.h
@@ -82,10 +84,10 @@ struct xt_get_revision
*/
struct _xt_align
{
- u_int8_t u8;
- u_int16_t u16;
- u_int32_t u32;
- u_int64_t u64;
+ u_int8_t align_u8;
+ u_int16_t align_u16;
+ u_int32_t align_u32;
+ u_int64_t align_u64;
};
#define XT_ALIGN(s) (((s) + (__alignof__(struct _xt_align)-1)) \
reply other threads:[~2007-01-29 22:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701291725.47920.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®