From: Avi Kivity <avi@qumranet.com>
To: kvm-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, mingo@elte.hu
Subject: [PATCH 1/11] KVM: optimize inline assembly
Date: Tue, 30 Jan 2007 14:37:00 -0000 [thread overview]
Message-ID: <20070130143700.0BB04A0014@il.qumranet.com> (raw)
In-Reply-To: <45BF57C9.7000103@qumranet.com>
From: Ingo Molnar <mingo@elte.hu>
forms like "0(%rsp)" generate an instruction with an unnecessary one byte
displacement under certain circumstances. replace with the equivalent
"(%rsp)".
Signed-off-by: Avi Kivity <avi@qumranet.com>
Index: linux-2.6/drivers/kvm/vmx.c
===================================================================
--- linux-2.6.orig/drivers/kvm/vmx.c
+++ linux-2.6/drivers/kvm/vmx.c
@@ -1784,10 +1784,10 @@ again:
"kvm_vmx_return: "
/* Save guest registers, load host registers, keep flags */
#ifdef CONFIG_X86_64
- "xchg %3, 0(%%rsp) \n\t"
+ "xchg %3, (%%rsp) \n\t"
"mov %%rax, %c[rax](%3) \n\t"
"mov %%rbx, %c[rbx](%3) \n\t"
- "pushq 0(%%rsp); popq %c[rcx](%3) \n\t"
+ "pushq (%%rsp); popq %c[rcx](%3) \n\t"
"mov %%rdx, %c[rdx](%3) \n\t"
"mov %%rsi, %c[rsi](%3) \n\t"
"mov %%rdi, %c[rdi](%3) \n\t"
@@ -1802,24 +1802,24 @@ again:
"mov %%r15, %c[r15](%3) \n\t"
"mov %%cr2, %%rax \n\t"
"mov %%rax, %c[cr2](%3) \n\t"
- "mov 0(%%rsp), %3 \n\t"
+ "mov (%%rsp), %3 \n\t"
"pop %%rcx; pop %%r15; pop %%r14; pop %%r13; pop %%r12;"
"pop %%r11; pop %%r10; pop %%r9; pop %%r8;"
"pop %%rbp; pop %%rdi; pop %%rsi;"
"pop %%rdx; pop %%rbx; pop %%rax \n\t"
#else
- "xchg %3, 0(%%esp) \n\t"
+ "xchg %3, (%%esp) \n\t"
"mov %%eax, %c[rax](%3) \n\t"
"mov %%ebx, %c[rbx](%3) \n\t"
- "pushl 0(%%esp); popl %c[rcx](%3) \n\t"
+ "pushl (%%esp); popl %c[rcx](%3) \n\t"
"mov %%edx, %c[rdx](%3) \n\t"
"mov %%esi, %c[rsi](%3) \n\t"
"mov %%edi, %c[rdi](%3) \n\t"
"mov %%ebp, %c[rbp](%3) \n\t"
"mov %%cr2, %%eax \n\t"
"mov %%eax, %c[cr2](%3) \n\t"
- "mov 0(%%esp), %3 \n\t"
+ "mov (%%esp), %3 \n\t"
"pop %%ecx; popa \n\t"
#endif
next prev parent reply other threads:[~2007-01-30 14:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-30 14:35 [PATCH 0/11] KVM updates for 2.6.21 Avi Kivity
2007-01-30 14:37 ` Avi Kivity [this message]
2007-01-30 14:38 ` [PATCH 2/11] KVM: Fix asm constraint for lldt instruction Avi Kivity
2007-01-30 14:55 ` Avi Kivity
2007-01-30 14:39 ` [PATCH 3/11] KVM: Fix gva_to_gpa() Avi Kivity
2007-01-30 14:40 ` [PATCH 4/11] KVM: vmx: handle triple faults by returning EXIT_REASON_SHUTDOWN to userspace Avi Kivity
2007-01-30 14:41 ` [PATCH 5/11] KVM: fix what looks like an obvious typo in the file drivers/kvm/svm.c Avi Kivity
2007-01-30 14:42 ` [PATCH 6/11] KVM: Fix mmu going crazy of guest sets cr0.wp == 0 Avi Kivity
2007-01-30 14:43 ` [PATCH 7/11] KVM: SVM: Hack initial cpu csbase to be consistent with intel Avi Kivity
2007-01-30 14:44 ` [PATCH 8/11] KVM: Two-way apic tpr synchronization Avi Kivity
2007-01-30 14:45 ` [PATCH 9/11] KVM: VMX: Reload ds and es even in 64-bit mode Avi Kivity
2007-01-30 14:46 ` [PATCH 10/11] KVM: Fix mismatch between 32-bit and 64-bit abi Avi Kivity
2007-01-30 14:47 ` [PATCH 11/11] KVM: fix vcpu freeing bug Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070130143700.0BB04A0014@il.qumranet.com \
--to=avi@qumranet.com \
--cc=akpm@osdl.org \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®