From: Oleg Verych <olecom@flower.upol.cz>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Roman Zippel <zippel@linux-m68k.org>,
Bastian Blank <bastian@waldi.eu.org>,
Sam Ravnborg <sam@ravnborg.org>, Andrew Morton <akpm@osdl.org>
Subject: [patch] update for (kbuild: correctly skip tilded backups in localversion files)
Date: Wed, 31 Jan 2007 09:35:42 +0000 [thread overview]
Message-ID: <20070131093542.GA3471@flower.upol.cz> (raw)
In-Reply-To: <20070131071103.GA3295@flower.upol.cz>
kbuild: finally correctly skip tilded backups in localversion files
Signed-off-by: Oleg Verych <olecom@flower.upol.cz>
---
Final addition. Why i want to maximize usage of shell, rather, than
`make'? Just because i think, it's more portable, clear way.
Thanks.
--- linux-2.6.20-rc6/Makefile~4tilde-backups~ 2007-01-31 07:46:18.696404500 +0100
+++ linux-2.6.20-rc6/Makefile 2007-01-31 10:19:18.406100500 +0100
@@ -788,10 +788,10 @@ $(vmlinux-dirs): prepare scripts
# scripts/setlocalversion and add the appropriate checks as needed.
-localversion = $(objtree)/localversion $(srctree)/localversion
-ext_versions = $(objtree)/localversion[^~]* $(srctree)/localversion[!~]*
-versions = $(localversion) $(ext_versions)
-localver = $(subst $(space),, \
- $(shell cat /dev/null $(sort $(wildcard $(versions)))) \
- $(patsubst "%",%,$(CONFIG_LOCALVERSION)))
+pattern = ".*/localversion[^~]*"
+string = $(shell cat /dev/null \
+ `find $(objtree) $(srctree) -maxdepth 1 -regex $(pattern) | sort`)
+
+localver = $(subst $(space),, $(string) \
+ $(patsubst "%",%,$(CONFIG_LOCALVERSION)))
# If CONFIG_LOCALVERSION_AUTO is set scripts/setlocalversion is called
next prev parent reply other threads:[~2007-01-31 9:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-31 7:11 [patch] kbuild: correctly skip tilded backups in localversion files Oleg Verych
2007-01-31 9:35 ` Oleg Verych [this message]
2007-01-31 23:56 ` Andrew Morton
2007-02-01 2:37 ` Oleg Verych
2007-02-01 2:43 ` Andrew Morton
2007-02-01 15:59 ` 2.6.20-rc7 (Re: [patch] kbuild: correctly skip tilded backups in localversion files) Oleg Verych
2007-02-04 14:01 ` [patch] kbuild: correctly skip tilded backups in localversion files Oleg Verych
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070131093542.GA3471@flower.upol.cz \
--to=olecom@flower.upol.cz \
--cc=akpm@osdl.org \
--cc=bastian@waldi.eu.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®