Re: [PATCH] VIA IRQ quirk breakage fix

[Jean Delvare <jdelvare@suse.de>]

Hi Andrew,

Le Mercredi 31 Janvier 2007 03:37, Andrew Morton a écrit :
> On Tue, 30 Jan 2007 13:25:58 +0100
>
> Jean Delvare <jdelvare@suse.de> wrote:
> > So here comes the third
> > (and hopefully last) iteration of the patch:
>
> argh, it looks like I sent v2 to Linus.
>
> Here's the missing bit.  Please confirm that we want it?

Yes, we want it. Please push it to Linus ASAP. Good thing we had this rc7 
after all :)

>
>
> From: Jean Delvare <jdelvare@suse.de>
>
> Add special handling for the VT82C686.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Cc: Nick Piggin <nickpiggin@yahoo.com.au>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> ---
>
>  drivers/pci/quirks.c |    8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff -puN drivers/pci/quirks.c~via-quirk-fix-update drivers/pci/quirks.c
> --- a/drivers/pci/quirks.c~via-quirk-fix-update
> +++ a/drivers/pci/quirks.c
> @@ -661,9 +661,11 @@ static void quirk_via_bridge(struct pci_
>  	/* See what bridge we have and find the device ranges */
>  	switch (dev->device) {
>  	case PCI_DEVICE_ID_VIA_82C686:
> -		/* 82C686 is special */
> -		via_vlink_dev_lo = 7;
> -		via_vlink_dev_hi = 7;
> +		/* The VT82C686 is special, it attaches to PCI and can have
> +		   any device number. All its subdevices are functions of
> +		   that single device. */
> +		via_vlink_dev_lo = PCI_SLOT(dev->devfn);
> +		via_vlink_dev_hi = PCI_SLOT(dev->devfn);
>  		break;
>  	case PCI_DEVICE_ID_VIA_8237:
>  	case PCI_DEVICE_ID_VIA_8237A:
> _

-- 
Jean Delvare
Suse L3